Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird Line Heights issue with Capital Letters on certain font sizes #11017

Closed
Lunchb0ne opened this issue Aug 23, 2021 · 7 comments
Closed

Weird Line Heights issue with Capital Letters on certain font sizes #11017

Lunchb0ne opened this issue Aug 23, 2021 · 7 comments
Labels
Area-Fonts Related to the font Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
22H2

Comments

@Lunchb0ne
Copy link

Windows Terminal version (or Windows build number)

1.10.1933.0

Other Software

No response

Steps to reproduce

I'm using JetBrainsMono NF as my terminal font. On some sizes like 11pt the character heights are all inconsistent.

Expected Behavior

Equal line Heights

Actual Behavior

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 23, 2021
@zadjii-msft
Copy link
Member

Curious, we've hit this before (#4367), but that was resolved over a year ago. Did this used to work in a previous version of the Terminal, with this font?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 23, 2021
@Lunchb0ne
Copy link
Author

Curious, we've hit this before (#4367), but that was resolved over a year ago. Did this used to work in a previous version of the Terminal, with this font?

I'm not sure, I recently switched to this and it's broken on both the stable and preview Windows Terminal

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 24, 2021
This was referenced Aug 25, 2021
Closed
Closed
@zadjii-msft
Copy link
Member

I don't think this is the same as #11032 - that looks more like Cascadia Code was missing entirely. This is more just JetBrains Mono NL Regular Nerd Font Complete.ttf doesn't render exactly correct

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 2, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 2, 2021
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements labels Sep 2, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 2, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Sep 2, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@serd2011
Copy link
Contributor

serd2011 commented Sep 5, 2022

Is this still relevant? I cant seem to repro this on Preview 1.15.2282.0

@Lunchb0ne
Copy link
Author

Sorry, I don't have access to Windows device for some time. I'll try to repro this ASAP.

@zadjii-msft
Copy link
Member

Hey, if you've got a Windows machine around, can you double check if this repros still/? Terminal Preview 1.16 has a new rendering engine that might have fixed this.

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. labels Dec 5, 2022
@ghost
Copy link

ghost commented Dec 10, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost ghost closed this as completed Dec 13, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Fonts Related to the font Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
22H2
Development

No branches or pull requests
4 participants
@DHowett @zadjii-msft @Lunchb0ne @serd2011