Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake command palette entry doesn't work #11014

Open
Tracked by #8888
warpdesign opened this issue Aug 23, 2021 · 1 comment
Open
Tracked by #8888

Quake command palette entry doesn't work #11014

warpdesign opened this issue Aug 23, 2021 · 1 comment
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@warpdesign
Copy link

warpdesign commented Aug 23, 2021

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

No response

Steps to reproduce

  • press ctrl+shift+p and type quake
  • select invoquer la fenêtre quake [win+ctrl+alt+7] and press enter

Expected Behavior

The quake console window should be opened.

Actual Behavior

Nothing happens.

Note that using the [win+ctrl+alt+7] keyboard shortcut works as expected.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 23, 2021
@zadjii-msft
Copy link
Member

Interesting. Good catch, that should probably work. TerminalPage::_HandleGlobalSummon should bubble the action up to the window regardless, and toss it to the monarch. That way the monarch can try the key even if we failed to globally bind it(!)

@zadjii-msft zadjii-msft added Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Aug 23, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Aug 23, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 27, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants