Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: yarn start should be included as a start script #1111

Closed
kg-currenxie opened this issue Jun 26, 2019 · 3 comments
Closed

Suggestion: yarn start should be included as a start script #1111

kg-currenxie opened this issue Jun 26, 2019 · 3 comments

Comments

@kg-currenxie
Copy link
Contributor

With RN, I always only use yarn start to start the metro bundler, and go to XCode and go to Product / Perform Action / Run without building. This saves 1-2 minutes of build time that yarn run:ios does.

You should include a normal yarn start script by default (generated by using create-xp-app), to make it more familiar to RN devs switching to RN-XP :)

I guess yarn run rn-cli start is the same, but still..

@mikehardy
Copy link
Contributor

I’m not sure this should be recommended, it’s an optimization but for me anyway it breaks ios9 (which must have a bundle in place / cannot use the dev server) if it were enabled by default. For people that want performance you should set the environment variable SKIP_BUNDLING to achieve the performance boost while still maintaining a “works everywhere” default stance facebook/react-native#14731

@erictraut
Copy link
Contributor

You're welcome to create any scripts you'd like within your own projects. I don't think it makes sense to add this to the reactxp sample apps.

@kg-currenxie
Copy link
Contributor Author

Didn't know it broke ios9 :D And haven't seen SKIP_BUNDLING before. Thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants