-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build visual tree compare tests that iterate over RNTester pages #4037
Comments
@kmelmon Is this issue providing any value beyond what you're already doing? Do you want me to dupe it to one of your issues or assign it over? |
I'll take this. I don't think it's a dupe so keeping it open for now. |
Alex has done some prototype level work on this: Here are the changes I made that but haven’t merged that I made:
here is the treedump library I wrote: and nuget: |
This is now part of https://github.com/microsoft/react-native-windows/projects/39 and depends directly on #6343 |
Plenty of tests for Text, other VMs to do listed in description. |
Notes from planning poker
|
Dumping each page would not be a viable solution. The test UI changes frequently, and there are elements not deterministic. |
I feel like this is superceded by #11422. @chiaramooney do you agree? Can we close this? |
@ddalp built out some visual tree comparison test infrastructure recently: #3754
We're going to use that more as we do new feature work, but we have a lot of test debt in everything we built before we had this or the general E2E test infrastructure. One thing we can do is take the existing content in RNTester and enumerate over it, grabbing a visual tree dump as we go. Even if it's just static (no interaction with the page), that's test coverage we don't have. Seems like a good way to bolster our test coverage.
Note that not all of the RNTester pages are testing ViewManagers. We should limit this task to only the RNTester pages that cover ViewManagers and their properties.
List of ViewManagers we want to cover - examples files in brackets:
Higher Priority / In Progress
Lower Priority
The text was updated successfully, but these errors were encountered: