Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Launch Accessibility Insights on E2E Fabric Test App #11594

Closed
chiaramooney opened this issue May 11, 2023 · 2 comments · Fixed by #11608
Closed

Cannot Launch Accessibility Insights on E2E Fabric Test App #11594

chiaramooney opened this issue May 11, 2023 · 2 comments · Fixed by #11608
Assignees
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric Area: ScrollView bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone

Comments

@chiaramooney
Copy link
Contributor

Problem Description

After pulling in the latest changes from main, launching Accessibility Insights on the E2E test app on Fabric results in an alert window being thrown. The alert windows states that an assert has been hit in the ScrollViewComponentView.cpp file (

).

Have not yet tested if this occurs for the playground app, but issue did not occur previously. The assert in line 222 has been present in the files since ScrollView has been present since the start of this file on Fabric, so we'll have to figure out why it is now being hit when Accessibility Insights is launched.

Steps To Reproduce

Run e2e-test-app-fabric.
Open Accessibility Insights.

Expected Results

No errors.

CLI version

npx react-native -v

Environment

npx react-native info

Target Platform Version

None

Target Device(s)

No response

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 11, 2023
@chrisglein chrisglein added Area: Accessibility Area: ScrollView Area: Fabric Support Facebook Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 11, 2023
@chrisglein chrisglein added this to the 0.73 milestone May 11, 2023
@chrisglein
Copy link
Member

chrisglein commented May 11, 2023

@chiaramooney Can you provide the callstack to know how it's being called?
This method isn't yet implemented.
We should make sure that the accessibility code isn't expecting view props from things that aren't view props.
Other than that, the fix would be to implement method.

Certainly this will block #11296
Not tracked in #11152 because it's not an end developer facing method.

@FalseLobster did you hit this when targeting a Fabric app?

@chiaramooney
Copy link
Contributor Author

chiaramooney commented May 11, 2023

Method is being called in CompositionDynamicAutomationProvider.cpp at line 210. It seems to be seeking...

 auto props = std::static_pointer_cast<const facebook::react::ViewProps>(strongView->props());
  if (props == nullptr)
    return UIA_E_ELEMENTNOTAVAILABLE;

Is all that's needed here to implement the method a return of m_props?
@acoates-ms for fyi.

@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric Area: ScrollView bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants