Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Snapshot Tests for TouchableHighlight #11310

Open
chiaramooney opened this issue Feb 27, 2023 · 0 comments
Open

Add E2E Snapshot Tests for TouchableHighlight #11310

chiaramooney opened this issue Feb 27, 2023 · 0 comments
Labels
Area: Fabric Support Facebook Fabric Area: Tests Area: TouchableHighlight enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Test Coverage Expand and update our new architecture test coverage.
Milestone

Comments

@chiaramooney
Copy link
Contributor

chiaramooney commented Feb 27, 2023

Add E2E snapshot tests for the TouchbleHighlight components. Snapshots should dump the contents of the Composition Visual Tree and the Accessibility Tree.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR TOUCHABLEHIGHLIGHT

Test Description Status (Paper) Status (Fabric) Notes
Default - Text Child
  • Sample Completed – RNTester
  • Completed
Default - Image Child
  • Sample Completed – RNTester
  • Completed
AccessibilityHint
  • Not Completed
  • Not Completed
AccessibilityLabel
  • Not Completed
  • Not Completed
AccessibilityActions
  • Not Completed
  • Not Completed
AccessibilityRole
  • Not Completed
  • Not Completed
AccessibilityValue
  • Not Completed
  • Not Completed
AccessibilityPosInSet
  • Not Completed
  • Completed
AccessibilitySetSize
  • Not Completed
  • Completed
AccessibilityLiveRegion
  • Not Completed
  • Completed
ImportantforAccessibility – no-hide-descendants
  • Not Completed
  • Not Completed
testID
  • Sample Completed – RNTester
  • Not Completed
Style – backgroundColor
  • Sample Completed – RNTester
  • Not Completed
Style – borderBottomColor Not Implemented
  • Not Completed
Style – borderBottomEndRadius
  • Not Completed
  • Not Completed
Style –borderBottomLeftRadius
  • Not Completed
  • Not Completed
Style – borderBottomRightRadius
  • Not Completed
  • Not Completed
Style – borderBottomStartRadius
  • Not Completed
  • Not Completed
Style – borderBottomWidth
  • Not Completed
  • Not Completed
Style – borderColor
  • Not Completed
  • Not Completed
Style – borderEndColor Not Implemented
  • Not Completed
Style – borderLeftColor Not Implemented
  • Not Completed
Style – borderLeftWidth
  • Not Completed
  • Not Completed
Style – borderRadius
  • Sample Completed – RNTester
  • Completed
Style – borderRightColor Not Implemented
  • Not Completed
Style – borderStartColor Not Implemented
  • Not Completed
Style – borderStyle
  • Not Completed
  • Not Completed
Style – borderTopColor Not Implemented
  • Not Completed
Style – borderTopEndRadius
  • Not Completed
  • Not Completed
Style – borderTopLeftRadius
  • Not Completed
  • Not Completed
Style – borderTopRightRadius
  • Not Completed
  • Not Completed
Style – borderTopStartRadius
  • Not Completed
  • Not Completed
Style – borderTopWidth
  • Not Completed
  • Not Completed
Style – borderWidth
  • Sample Completed – RNTester
  • Not Completed
Style – elevation Not Implemented
  • Not Completed
Style – opacity
  • Not Completed
  • Not Completed
Style – height
  • Not Completed
  • Not Completed
Style – width
  • Not Completed
  • Not Completed
Style – overflow
  • Not Completed
  • Not Completed
Style – backfaceVisibility
  • Not Completed
  • Not Completed
Accessible
  • Not Completed
  • Not Completed
Focusable
  • Not Completed
  • Not Completed
HitSlop
  • Not Completed
  • Not Completed
NativeID
  • Not Completed
  • Not Completed
NextFocus*
  • Not Completed
  • Not Completed
onAccessibilityAction
  • Not Completed
  • Not Completed
onAccessibilityTab
  • Not Completed
  • Not Completed
onAccessibilityEscape
  • Not Completed
  • Not Completed
onLayout
  • Not Completed
  • Not Completed
onMoveShoudlSetResponder
  • Not Completed
  • Not Completed
onMoveShouldSetResponderCapture
  • Not Completed
  • Not Completed
onResponderGrant
  • Not Completed
  • Not Completed
onResponderMove
  • Not Completed
  • Not Completed
onResponserReject
  • Not Completed
  • Not Completed
onResponderRelease
  • Not Completed
  • Not Completed
onResponderTerminate
  • Not Completed
  • Not Completed
onResponderTerminationRequest
  • Not Completed
  • Not Completed
onStartShouldSetResponder
  • Not Completed
  • Not Completed
onStartShouldSetResponderCatpure
  • Not Completed
  • Not Completed
pointerEvents
  • Not Completed
  • Not Completed
removeClippedSubviews
  • Not Completed
  • Not Completed
needsOffscreenAlphaCompositioning
  • Not Completed
  • Not Completed
toolTip
  • Not Completed
  • Not Completed
activeOpacity
  • Sample Completed – RNTester
  • Completed
onHideUnderlay
  • Sample Completed – RNTester
  • Sample Completed
onShowUnderlay
  • Sample Completed – RNTester
  • Sample Completed
underlayColor
  • Sample Completed – RNTester
  • Completed
testOnly_pressed
  • Not Completed
  • Not Completed
onPress
  • Sample Completed – RNTester
  • Completed
onPressIn
  • Not Completed
  • Not Completed
onLongPress
  • Not Completed
  • Not Completed
delayPressIn
  • Not Completed
  • Not Completed
delayPressOut
  • Not Completed
  • Not Completed
delayLongPress
  • Not Completed
  • Not Completed
disabled
  • Sample Completed – RNTester
  • Sample Completed
onFocus
  • Sample Completed – RNTester
  • Not Completed
onBlur
  • Not Completed
  • Not Completed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 27, 2023
@chrisglein chrisglein added enhancement Area: Tests Area: Fabric Support Facebook Fabric Area: TouchableHighlight and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Mar 6, 2023
@chrisglein chrisglein added this to the Backlog milestone Mar 6, 2023
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@chiaramooney chiaramooney added the Workstream: Test Coverage Expand and update our new architecture test coverage. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Fabric Support Facebook Fabric Area: Tests Area: TouchableHighlight enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Test Coverage Expand and update our new architecture test coverage.
Projects
Status: No status
Development

No branches or pull requests

4 participants