Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there is a sample that demonstrates mouse hover #541

Closed
chrisglein opened this issue Sep 20, 2021 · 6 comments
Closed

Ensure there is a sample that demonstrates mouse hover #541

chrisglein opened this issue Sep 20, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request samples
Milestone

Comments

@chrisglein
Copy link
Member

This question comes up often. And if a question comes up often... that means we need better documentation and we need samples that capture common scenarios.

There's a big thread here about an effort to make the hover states (and other mouse-centric things) more unified across all platforms. There are options to do what you want in RNW today, but they're underdocumented (for example compared to the keyboard props). The lack of documentation on these props is tracked here.

There are some running examples in this repo, like this. But I don't see anything proper on the samples repo.

Documentation: Known to be missing.

Samples: We could either create a new sample that focuses on mouse hover. Or we could add usage examples to an existing sample (Calculator?) as long as it didn't contort what that sample was trying to demonstrate. Or we could add it to react-native-gallery as a usage example of core components. Whatever we do, it needs to be discoverable and easily linkable.

@chrisglein chrisglein added enhancement New feature or request samples labels Sep 20, 2021
@chrisglein chrisglein added this to the 0.67 milestone Sep 20, 2021
@ghost ghost added the Needs: Triage 🔍 label Sep 20, 2021
@rectified95 rectified95 self-assigned this Sep 20, 2021
@chrisglein chrisglein modified the milestones: 0.67, 0.68 Jan 12, 2022
@crutchcorn
Copy link

I'd be happy to build out examples and docs for onMouseEnter and onMouseLeave if that would be helpful :)

If so, though, I'd need to know what kind of sample we'd want (there seems to be a few options).

@TatianaKapos
Copy link
Contributor

@crutchcorn That would be super helpful if you have the time! I think we're still deciding what would be the best course to go with in term of MouseEvents.

@chrisglein IMO I would lean towards having a separate example app to demonstrate mouse events (Calculator is a pretty good simple app and I wouldn't want to further complicate it), especially since we may build upon mouse events in the future, having a stand-alone app means we can just add to it.

@crutchcorn
Copy link

Just wanted to double-check on this - I'm still willing/wanting to write docs but want to make sure that I'm doing work that aligns with the goal here :)

Should it still be a docs page IKeyboardView and an example app?

@TatianaKapos
Copy link
Contributor

@crutchcorn I think we're going to hold off on the example app as mouse events are in the process of being look at.

but our current documentation is definitely lacking so anything you can/want to add there (either creating or adding to a document page) would be much appreciated and I'm sure we'll get use out of! :)

@chrisglein chrisglein modified the milestones: 0.68, 0.69 Mar 23, 2022
@jonthysell
Copy link
Contributor

@TatianaKapos Is this still something that makes sense for 0.69 or should it be moved to 0.70?

@TatianaKapos
Copy link
Contributor

@jonthysell I actually will have a PR later today to add this example to gallery, will hopefully make .69 but can be moved to .70 if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request samples
Projects
None yet
Development

No branches or pull requests

5 participants