-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure there is a sample that demonstrates mouse hover #541
Comments
I'd be happy to build out examples and docs for If so, though, I'd need to know what kind of sample we'd want (there seems to be a few options). |
@crutchcorn That would be super helpful if you have the time! I think we're still deciding what would be the best course to go with in term of MouseEvents. @chrisglein IMO I would lean towards having a separate example app to demonstrate mouse events (Calculator is a pretty good simple app and I wouldn't want to further complicate it), especially since we may build upon mouse events in the future, having a stand-alone app means we can just add to it. |
Just wanted to double-check on this - I'm still willing/wanting to write docs but want to make sure that I'm doing work that aligns with the goal here :) Should it still be a docs page |
@crutchcorn I think we're going to hold off on the example app as mouse events are in the process of being look at. but our current documentation is definitely lacking so anything you can/want to add there (either creating or adding to a document page) would be much appreciated and I'm sure we'll get use out of! :) |
@TatianaKapos Is this still something that makes sense for 0.69 or should it be moved to 0.70? |
@jonthysell I actually will have a PR later today to add this example to gallery, will hopefully make .69 but can be moved to .70 if needed |
This question comes up often. And if a question comes up often... that means we need better documentation and we need samples that capture common scenarios.
Documentation: Known to be missing.
Samples: We could either create a new sample that focuses on mouse hover. Or we could add usage examples to an existing sample (Calculator?) as long as it didn't contort what that sample was trying to demonstrate. Or we could add it to react-native-gallery as a usage example of core components. Whatever we do, it needs to be discoverable and easily linkable.
The text was updated successfully, but these errors were encountered: