Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there exists a number of bugs in \qlib\scripts\data_collector\cn_index\collector.py #1065

Closed
FluidDoctor opened this issue Apr 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@FluidDoctor
Copy link

there exists a number of bugs in \qlib\scripts\data_collector\cn_index\collector.py

  1. line 333, it shoulde be "class CSI100Index", not now "class CSI100" AND in line 344, it shoulde be "return 1". after make these changes, run python collector.py --index_name CSI100 --qlib_dir ~/.qlib/qlib_data/cn_data --method parse_instruments will give a correct response.
  2. line 330, it shoulde be "return 0", not now "return 1". "return 1" can give a results but not correct. after make this change, can not work ,will raise error like this "scripts\data_collector\cn_index\collector.py", line 160, in normalize_symbol
    symbol = f"{int(symbol):06}"
    ValueError: cannot convert float NaN to integer"
    I have tried to fix this bug, but unlikely, unsuccess.
@FluidDoctor FluidDoctor added the bug Something isn't working label Apr 21, 2022
@SunsetWolf
Copy link
Collaborator

I am glad to receive your very organized questions.

  1. The class name of csi100 has been fixed in PR 1046.
    The return value of the html_table_index method in the CSI100Index class has been fixed in PR 1070.
  2. The return value of the html_table_index method in the CSI300Index class has been fixed in PR 1070.
    ValueError: cannot convert float NaN to integer has been fixed in PR 1046.
    I hope my reply can help you, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants