From 2f98b5e26ab1b0b4a9dd4b27efe027a827046639 Mon Sep 17 00:00:00 2001 From: Pavel Date: Mon, 2 Mar 2020 15:08:15 -0800 Subject: [PATCH] test: mark some tests as skipped (2) --- test/click.spec.js | 6 +++--- test/elementhandle.spec.js | 2 +- test/emulation.spec.js | 26 +++++++++++++++----------- test/popup.spec.js | 2 +- test/screenshot.spec.js | 2 +- 5 files changed, 21 insertions(+), 17 deletions(-) diff --git a/test/click.spec.js b/test/click.spec.js index b0e6aea876416..605eb5ad83efc 100644 --- a/test/click.spec.js +++ b/test/click.spec.js @@ -240,8 +240,8 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI await page.click('button.does-not-exist', { waitFor: false }).catch(e => error = e); expect(error.message).toBe('No node found for selector: button.does-not-exist'); }); - // @see https://github.com/GoogleChrome/puppeteer/issues/161 - it('should not hang with touch-enabled viewports', async({server, browser}) => { + it.skip(FFOX)('should not hang with touch-enabled viewports', async({server, browser}) => { + // @see https://github.com/GoogleChrome/puppeteer/issues/161 const context = await browser.newContext({ viewport: playwright.devices['iPhone 6'].viewport }); const page = await context.newPage(); await page.mouse.down(); @@ -378,7 +378,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI expect(await page.evaluate(() => offsetX)).toBe(WEBKIT ? 1900 + 8 : 1900); expect(await page.evaluate(() => offsetY)).toBe(WEBKIT ? 1910 + 8 : 1910); }); - it('should click the button with offset with page scale', async({browser, server}) => { + it.skip(FFOX)('should click the button with offset with page scale', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 400, height: 400, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/input/button.html'); diff --git a/test/elementhandle.spec.js b/test/elementhandle.spec.js index f15ecf740cd79..4393c3f0ebd30 100644 --- a/test/elementhandle.spec.js +++ b/test/elementhandle.spec.js @@ -68,7 +68,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) }, element); expect(pwBoundingBox).toEqual(webBoundingBox); }); - it('should work with page scale', async({browser, server}) => { + it.skip(FFOX)('should work with page scale', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 400, height: 400, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/input/button.html'); diff --git a/test/emulation.spec.js b/test/emulation.spec.js index 9ed3d6d898086..e1e1b00512ec6 100644 --- a/test/emulation.spec.js +++ b/test/emulation.spec.js @@ -38,6 +38,16 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect(await page.evaluate(() => window.innerWidth)).toBe(123); expect(await page.evaluate(() => window.innerHeight)).toBe(456); }); + it('should not have touch by default', async({page, server}) => { + await page.goto(server.PREFIX + '/mobile.html'); + expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false); + await page.goto(server.PREFIX + '/detect-touch.html'); + expect(await page.evaluate(() => document.body.textContent.trim())).toBe('NO'); + }); + }); + + describe.skip(FFOX)('viewport.isMobile', () => { + // Firefox does not support isMobile. it('should support mobile emulation', async({browser, server}) => { const context = await browser.newContext({ viewport: iPhone.viewport }); const page = await context.newPage(); @@ -47,12 +57,6 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect(await page.evaluate(() => window.innerWidth)).toBe(400); await context.close(); }); - it('should not have touch by default', async({page, server}) => { - await page.goto(server.PREFIX + '/mobile.html'); - expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false); - await page.goto(server.PREFIX + '/detect-touch.html'); - expect(await page.evaluate(() => document.body.textContent.trim())).toBe('NO'); - }); it('should support touch emulation', async({browser, server}) => { const context = await browser.newContext({ viewport: iPhone.viewport }); const page = await context.newPage(); @@ -89,7 +93,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect(await page.evaluate(() => Modernizr.touchevents)).toBe(true); await context.close(); }); - it.fail(FFOX)('should support landscape emulation', async({browser, server}) => { + it('should support landscape emulation', async({browser, server}) => { const context1 = await browser.newContext({ viewport: iPhone.viewport }); const page1 = await context1.newPage(); await page1.goto(server.PREFIX + '/mobile.html'); @@ -100,7 +104,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF await context1.close(); await context2.close(); }); - it.fail(FFOX || WEBKIT)('should fire orientationchange event', async({browser, server}) => { + it.fail(WEBKIT)('should fire orientationchange event', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 300, height: 400, isMobile: true } }); const page = await context.newPage(); await page.goto(server.PREFIX + '/mobile.html'); @@ -118,14 +122,14 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect((await event2).text()).toBe('2'); await context.close(); }); - it.fail(FFOX)('default mobile viewports to 980 width', async({browser, server}) => { + it('default mobile viewports to 980 width', async({browser, server}) => { const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/empty.html'); expect(await page.evaluate(() => window.innerWidth)).toBe(980); await context.close(); }); - it.fail(FFOX)('respect meta viewport tag', async({browser, server}) => { + it('respect meta viewport tag', async({browser, server}) => { const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/mobile.html'); @@ -134,7 +138,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF }); }); - describe('Page.emulate', function() { + describe.skip(FFOX)('Page.emulate', function() { it('should work', async({browser, server}) => { const context = await browser.newContext({viewport: iPhone.viewport, userAgent: iPhone.userAgent}); const page = await context.newPage(); diff --git a/test/popup.spec.js b/test/popup.spec.js index 9163e8d5fa1df..f14e63a1e3add 100644 --- a/test/popup.spec.js +++ b/test/popup.spec.js @@ -61,7 +61,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE await context.close(); expect(hasTouch).toBe(true); }); - it.fail(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) { + it.skip(FFOX).fail(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) { const context = await browser.newContext({ viewport: { width: 400, height: 500 } }); diff --git a/test/screenshot.spec.js b/test/screenshot.spec.js index 68a11450ea360..9249557ddded9 100644 --- a/test/screenshot.spec.js +++ b/test/screenshot.spec.js @@ -156,7 +156,7 @@ module.exports.describe = function({testRunner, expect, product, FFOX, CHROMIUM, }); expect(Buffer.from(screenshot, 'base64')).toBeGolden('screenshot-sanity.png'); }); - it.fail(FFOX)('should work with a mobile viewport', async({browser, server}) => { + it.skip(FFOX)('should work with a mobile viewport', async({browser, server}) => { const context = await browser.newContext({viewport: { width: 320, height: 480, isMobile: true }}); const page = await context.newPage(); await page.goto(server.PREFIX + '/overflow.html');