Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class notebook create fails #1478

Closed
darius-m opened this issue Nov 25, 2020 · 2 comments · Fixed by #1528 or #1529
Closed

Class notebook create fails #1478

darius-m opened this issue Nov 25, 2020 · 2 comments · Fixed by #1528 or #1529
Assignees

Comments

@darius-m
Copy link
Contributor

There have been quite a few class notebooks creation tasks that have failed, resulting in extremely long runs of the usergroups task (up to 30 mintutes), and even database timeouts. After adding an mtrace message in the catch block in replace_group_notebook_job, I have noticed that the notebooks have not been created, and the reason given was Error in API call: The request does not contain a valid authentication token..

I am not sure when this started to happen, but it may have been some time. Has there been a change in the Microsoft API that causes these issues? Also, I would like to ask to have the message permanently added to the code base, as silent failures are not usually desired.

@weilai-irl
Copy link
Collaborator

Hi @darius-m,

I confirm there is an issue when in the process to get an access token when calling OneNote Graph APIs using application access. The steps to get access token using application access for OneNote Graph API is apparently different from the steps to get access token for the latest Microsoft Graph API. I also confirm that there isn't an API function available in the Microsoft Graph API to create class notebook for a group.

Taking a step back, since the most probable use case for the plugin now is to create Teams instead of groups, the feature to convert a Notebook created for a group into a class Notebook isn't a necessary step any more. Therefore a decision has been made to remove this step in the next release. This should have no impact on the remaining features.

Please try this again when the new version is release later this month, and see if this solve the issues reported.

Regards,
Lai

@weilai-irl weilai-irl added this to the Release 2021-01 milestone Jan 8, 2021
@weilai-irl
Copy link
Collaborator

Hi @darius-m,

As per my last note, the function to convert a Notebook created for a group into a class Notebook has been removed in the latest release 3.9.3 and 3.10.0.

I'll close the issue for now just so that we can mark the milestone closed. Feel free to reopen it if you see any issue caused by this change.

Regards,
Lai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment