Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Add some way of prepending the url prefix value to all of the included static files, etc. #3739

Closed
rmfan opened this issue Jun 8, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request user raised

Comments

@rmfan
Copy link
Contributor

rmfan commented Jun 8, 2021

What would you like to be added:

Right now there is a flag --url_prefix to have the UI be available at http://<ip>:<port>/<url_prefix>. I would also like some way for the UI's dependent javascript, css, etc files to be located at http://<ip>:<port>/<url_prefix>/static instead of http://<ip>:<port>/static. This may be similar to Tensorboard's --path_prefix flag.

Why is this needed:

When http://<ip>:<port>/ (or http://<ip>:<port>/static) is not available, then the front end on http://<ip>:<port>/<url_prefix> produces errors. This may occur when the NNI UI is behind a reverse proxy like Nginx.

Without this feature, how does current nni work

NNI's UI does not display anything if http://<ip>:<port>/static is not available

Components that may involve changes:

ts/webui

Brief description of your proposal if any:

@liuzhe-lz
Copy link
Contributor

liuzhe-lz commented Jun 9, 2021

Thanks for your report. But seems we are too late for v2.3 release.
For now I suggest to workaround by copying static files to reverse proxy's path and add a special rule. All NNI experiments share same static files so this should work.
We will fix this in v2.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request user raised
Projects
None yet
Development

No branches or pull requests

3 participants