You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On this PR, microsoft/mu_plus#22 some comments were made that weren't addressed but it was agreed they would be addressed in a future PR.
Mike K:
The use of the term 'Shared' 'SHARED' should be removed from all types, variables, functions, library, and module names. The private protocol/ppi/smm protocol are an abstraction for the CryptoPkg/Include/BaseCryptLib.h, so the name of the protocol and the modules should make this relationship obvious. Perhaps using the names listed below for includes. The use of 'Base' in the name of the library class is unfortunate. The term 'Base' in the name of a lib instance implies module compatibility with all module types. Private/Protocol/BaseCrypt.h EDKII_BASE_CRYPT_PROTOCOL_GUID EDKII_BASE_CRYPT_PROTOCOL gEdkiiBaseCryptProtocolGuid Private/Protocol/SmmBaseCrypt.h EDKII_SMM_BASE_CRYPT_PROTOCOL_GUID EDKII_SMM_BASE_CRYPT_PROTOCOL gEdkiiSmmBaseCryptProtocolGuid Private/Ppi/BaseCrypt.h EDKII_PEI_BASE_CRYPT_PROTOCOL_GUID EDKII_PEI_BASE_CRYPT_PROTOCOL gEdkiiPeiBaseCryptProtocolGuid Library Instances (not using keyword 'Base') DxeCryptLibOnProtocol SmmCryptLibOnProtocol PeiCryptLibOnPpi Drivers CryptDxe CryptSmm CryptPei We could define a few feature flag PCDs that select between a NULL value and function pointer value when filling in the structure of crypto services. This can reduce the number of INFs and C files. Can we also consider making this a pull request against CryptoPkg in mu_tiano_plus?
There was also the issue of moving the publishing tools outside the code itself
The text was updated successfully, but these errors were encountered:
On this PR, microsoft/mu_plus#22 some comments were made that weren't addressed but it was agreed they would be addressed in a future PR.
Mike K:
The use of the term 'Shared' 'SHARED' should be removed from all types, variables, functions, library, and module names. The private protocol/ppi/smm protocol are an abstraction for the CryptoPkg/Include/BaseCryptLib.h, so the name of the protocol and the modules should make this relationship obvious. Perhaps using the names listed below for includes. The use of 'Base' in the name of the library class is unfortunate. The term 'Base' in the name of a lib instance implies module compatibility with all module types. Private/Protocol/BaseCrypt.h EDKII_BASE_CRYPT_PROTOCOL_GUID EDKII_BASE_CRYPT_PROTOCOL gEdkiiBaseCryptProtocolGuid Private/Protocol/SmmBaseCrypt.h EDKII_SMM_BASE_CRYPT_PROTOCOL_GUID EDKII_SMM_BASE_CRYPT_PROTOCOL gEdkiiSmmBaseCryptProtocolGuid Private/Ppi/BaseCrypt.h EDKII_PEI_BASE_CRYPT_PROTOCOL_GUID EDKII_PEI_BASE_CRYPT_PROTOCOL gEdkiiPeiBaseCryptProtocolGuid Library Instances (not using keyword 'Base') DxeCryptLibOnProtocol SmmCryptLibOnProtocol PeiCryptLibOnPpi Drivers CryptDxe CryptSmm CryptPei We could define a few feature flag PCDs that select between a NULL value and function pointer value when filling in the structure of crypto services. This can reduce the number of INFs and C files. Can we also consider making this a pull request against CryptoPkg in mu_tiano_plus?
There was also the issue of moving the publishing tools outside the code itself
The text was updated successfully, but these errors were encountered: