WinUI3 Preview 3 package misses globbing pattern for PRIResource

[huoyaoyuan]

Issues I've met when upgrading a functioning project from preview2 to preview3:

Can't find ResourceMap:

#3620 (comment)
/cc @roxk

Cause:

The preview 3 nuget package doesn't include a glob pattern for PRIResource, while preview 2.

Workaround:

Add this to your project file:

  <ItemGroup>
    <PRIResource Include="Strings\**\*.resw" />
    <!-- Strings may be changed to other folder you use, or just **\*.resw -->
  </ItemGroup>

### XamlParseException

onecoreuap\base\appmodel\statemanager\winrt\lib\windows.storage.applicationdatafactory.server.cpp(235)\Windows.Storage.ApplicationData.dll!00007FFD72EF83F3: (caller: 00007FFD72F087B3) ReturnHr(1) tid(695c) 8000000B 该操作尝试访问的数据超出了有效范围

Wrapped by XamlParseException.

Currently no idea. Investigating.

Edit: this one should be unrelated.

[roxk]

@huoyaoyuan Thanks for the heads up. In my case, I found that the .resw files are already included in the project file so my crash seems to be different than yours. Specifically, XXX.Label and XXX.Text works fine, but XXX.ToolTipService.ToolTip would crash. Workaround is just removing these tool tip resources😅 I will file a new issue once I have a minimal repro.

[stevenbrix]

Interesting, I'm not aware of anything that would have changed here. @rohanp-msft, do you know if this is due to using the new PRI gen tooling?

[rohanp-msft]

Interesting, I'm not aware of anything that would have changed here. @rohanp-msft, do you know if this is due to using the new PRI gen tooling?

looking now

[rohanp-msft]

@huoyaoyuan Hi Huo, what kind of winui3 project is this? Examples are below:

[huoyaoyuan]

@rohanp-msft C# desktop, packaged. The project was manually updated from preview 2, which didn't request adding entry.

[rohanp-msft]

@stevenbrix For C# desktop, packaged apps, no, the new PRI gen tooling didn't introduce the need to do this. (The reason I asked about the type of project is that for class lib projects, I noticed that, both with winui 2 and 3, string resources don't make it into the class lib's PRI. That's what I'm working on figuring out now.)
CC @huoyaoyuan

[huoyaoyuan]

@rohanp-msft I mistyped it. I was using C# classlib.

[rohanp-msft]

@huoyaoyuan Huo, that's something I've seen before. I tried to repro it today but couldn't. Here's the issue where I recorded my repro attempt: microsoft/WindowsAppSDK#246
Can you repro it with a new WinUI class lib project? If yes, can you share your setup like what I shared in the link, please?

[huoyaoyuan]

@rohanp-msft Adding a resw using Visual Studio dialog adds <PRIResource Include="Resources.resw" /> in the project file. If it's commented out, Visual Studio shows it as None.

[rohanp-msft]

@huoyaoyuan Was that line present in the project file before you upgraded to WinUI 3.0 from WinUI 2.0? Did it go away after the upgrade?

[huoyaoyuan]

@rohanp-msft I upgraded from WinUI 3 Preview 2. Preview 2 didn't require the line. I did the upgrade manually.

[rohanp-msft]

OK, thanks for the info, @huoyaoyuan. I'll try to repro that (creating a new WinUI 3 Preview 3 project works for me, but if I try upgrading to it, perhaps it won't).

[rohanp-msft]

@huoyaoyuan Would you please share the pre-migration project file? Or point me to it?

[sjb-sjb]

I had a similar problem. In addition to adding the globbing pattern in a PRIResource tag, I had to go to each of the various .resw files in my project and verify that the build action was set to PRIResource. Even though all of the .resw files were added to the project in the same manner (by copying them into the project directory using FIle Explorer) some of them had the PRIResource build action while others did not.

Comment: at first, I accidentally (and incorrectlyi) used a path such as

<PRIResource Include="\**\Library\**\*.resw" />

This caused massive problems including for example extremely long time to just Clean the solution.

[JeanRoca]

@huoyaoyuan this should be fixed by RTM.

[huoyaoyuan]

Preview 4 behaves the same with Preview 3. Waiting for it.

[huoyaoyuan]

@JeanRoca It's still missing in Reunion 0.5.

[rohanp-msft]

@JeanRoca It's still missing in Reunion 0.5.

Hi @huoyaoyuan,
As you pointed out, this falls under microsoft/WindowsAppSDK#613.
You beat me to suggesting duping this to that bug.
Sorry about the delay here. The issue was not fully understood until recently.
The fix should be available in v0.8 preview of Project Reunion which starts shipping this month.
Please follow microsoft/WindowsAppSDK#613 to track completion.
Feel free to dupe this issue to microsoft/WindowsAppSDK#613.

[huoyaoyuan]

Solved in 0.8 stable.