Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: MUXC ScrollView should implement IScrollAnchorProvider #3164

Closed
marcelwgn opened this issue Aug 19, 2020 · 7 comments
Closed

Proposal: MUXC ScrollView should implement IScrollAnchorProvider #3164

marcelwgn opened this issue Aug 19, 2020 · 7 comments
Assignees
Labels
area-Scrolling feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@marcelwgn
Copy link
Collaborator

Proposal: MUXC ScrollView should implement IScrollAnchorProvider

Summary

The muxc ScrollView should implement the IScrollAnchorProvider interface, just like the wuxc version does.

Rationale

  • Consistency with wuxc ScrollViewer
  • Makes it easier to switch to muxc ScrollViewer

Scope

Capability Priority
Be consistent with existing wuxc ScrollViewer Must

Important Notes

@marcelwgn marcelwgn added the feature proposal New feature proposal label Aug 19, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 19, 2020
@StephenLPeters
Copy link
Contributor

@RBrid I'm surprised this isn't already the case.. I this a bug or a feature proposal?

@StephenLPeters StephenLPeters added area-Scrolling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Aug 19, 2020
@marcelwgn
Copy link
Collaborator Author

The interesting thing is that ScrollPresenter does implement that interface, but the ScrollView which contains a ScrollPresenter does not.

@RBrid
Copy link
Contributor

RBrid commented Aug 19, 2020

Yes this is intentional - By Design. The ScrollView publicly exposes the three IScrollAnchorProvider APIs and delegates the calls to its inner ScrollPresenter which actually implements the interface.

@marcelwgn
Copy link
Collaborator Author

@RBrid ScrollView does implement RegisterAnchorCandidate and UnregisterAnchorCandidate, but I can't seem to find the CurrentAnchor property that IScrollAnchorProvider has. Is it missing in the docs or is this intentional too?

@RBrid
Copy link
Contributor

RBrid commented Aug 19, 2020

I added it recently - it should be in the code at least: see #2936 "Adding public ScrollView.CurrentAnchor read-only property"

I mentioned "I updated the ScrollView spec reviewed here microsoft/microsoft-ui-xaml-specs#56 accordingly."

@marcelwgn
Copy link
Collaborator Author

Oh must have missed that PR, sorry about that. In that case, there isn't anything to track with this issue then, given that it is by design to not implement the interface on ScrollView but instead on ScrollPresenter.

@RBrid
Copy link
Contributor

RBrid commented Aug 19, 2020

Thank you Marcel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Scrolling feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants