Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with TabView control #2995

Closed
mrlacey opened this issue Jul 27, 2020 · 3 comments
Closed

Accessibility issue with TabView control #2995

mrlacey opened this issue Jul 27, 2020 · 3 comments

Comments

@mrlacey
Copy link
Contributor

mrlacey commented Jul 27, 2020

Describe the bug

The TabView control fails basic accessibility tests because it does not implement the selection pattern.

Steps to reproduce the bug

  1. Add a TabView control to a page
    <winui:TabView>
        <winui:TabViewItem Header="first"/>
        <winui:TabViewItem Header="second"/>
    </winui:TabView>
  1. Run app
  2. Test the app with Accessibility Insights for Windows

Expected behavior

The default behavior of the control should not contain anything that causes it to fail basic accessibility checks.
Specifically Section 508 502.3.10.

Screenshots

image

Version Info

NuGet package version: Microsoft.UI.Xaml 2.4.2

Windows 10 version Saw the problem?
Insider Build (20175) Yes
May 2020 Update (19041) Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

This was discovered while reviewing the accessibility of applications generated by Windows Template Studio. (microsoft/TemplateStudio#3723)

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 27, 2020
@marcelwgn
Copy link
Collaborator

This was fixed with #2856 .

@Felix-Dev
Copy link
Contributor

@mrlacey This is fixed by PR #2856 I believe.

@mrlacey
Copy link
Contributor Author

mrlacey commented Jul 27, 2020

Closing as duplicate of #2856 but still happens with 2.5.0-prerelease.200708003

@mrlacey mrlacey closed this as completed Jul 27, 2020
@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants