Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView appears to not be implementing the Selection pattern #2847

Closed
YuliKl opened this issue Jul 6, 2020 · 4 comments · Fixed by #2856
Closed

TabView appears to not be implementing the Selection pattern #2847

YuliKl opened this issue Jul 6, 2020 · 4 comments · Fixed by #2856
Labels
accessibility Narrator, keyboarding, UIA, etc area-TabView team-Controls Issue for the Controls team
Milestone

Comments

@YuliKl
Copy link

YuliKl commented Jul 6, 2020

I copied two TabView samples out of the Xaml Controls Gallery. Accessibility Insights for Windows identified this as a problem.

The following accessibility issue needs investigation.

App: WinUI_2-4_Test

Element path: tab ''

Issue Details: An element of the given ControlType must support the Selection pattern. Section 508 502.3.10

How To Fix: 1. Make sure the element has the appropriate ControlType property for its function.
2. If the current ControlType is correct, modify the element to support the Selection pattern.

This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.

@YuliKl YuliKl added accessibility Narrator, keyboarding, UIA, etc area-TabView labels Jul 6, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 6, 2020
@StephenLPeters StephenLPeters added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 6, 2020
@StephenLPeters
Copy link
Contributor

@teaP FYI

@StephenLPeters StephenLPeters added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Jul 6, 2020
@marcelwgn
Copy link
Collaborator

@teaP I assume you will be looking into this issue? Or would you like me to/would you be fine with me looking into this? @ranjeshj FYI

@ranjeshj ranjeshj added this to the WinUI 2.5 milestone Jul 7, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Jul 7, 2020

@chingucoding go for it. TabView uses ListView under the covers which should be implementing the selection pattern. Perhaps there is some wire up missing.

@teaP
Copy link
Contributor

teaP commented Jul 7, 2020

The list inside tabview (the tab strip, if you will) has the selection pattern. I'm not certain if that is good enough or if there is some other adjustment that should be made.

@ranjeshj ranjeshj removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Narrator, keyboarding, UIA, etc area-TabView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants