Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabViewItem does not respect theme resource TabViewItemHeaderForeground #2347

Closed
Felix-Dev opened this issue Apr 27, 2020 · 1 comment · Fixed by #2348
Closed

TabViewItem does not respect theme resource TabViewItemHeaderForeground #2347

Felix-Dev opened this issue Apr 27, 2020 · 1 comment · Fixed by #2348
Labels
area-TabView team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

Describe the bug
Changing the theme resource TabViewItemHeaderForeground does not change the foreground of the TabViewItem's header as expected. See this XAML:

<muxc:TabView>
    <muxc:TabView.Resources>
        <SolidColorBrush x:Key="TabViewItemHeaderForeground" Color="Green" />
        <SolidColorBrush x:Key="TabViewItemHeaderForegroundSelected" Color="LightGreen" />
    </muxc:TabView.Resources>
</muxc:TabView>

The look we get is this:
image

Expected behavior
image

NuGet package version:
Microsoft.UI.Xaml v2.4.0-prerelease.200422001

Additional context
I would like to fix this.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 27, 2020
@ranjeshj ranjeshj added area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 28, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

🎉This issue was addressed in #2348, which has now been successfully released as Microsoft.UI.Xaml v2.5.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
3 participants