Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and Re-enable NavigationView interaction Tests #1818

Closed
ojhad opened this issue Jan 8, 2020 · 1 comment
Closed

Fix and Re-enable NavigationView interaction Tests #1818

ojhad opened this issue Jan 8, 2020 · 1 comment
Assignees
@ojhad
Labels
area-NavigationView NavView control bug Something isn't working no-issue-activity team-Controls Issue for the Controls team test issue Issue with test code

Comments

@ojhad
Copy link
Contributor

ojhad commented Jan 8, 2020 •
edited
Loading

There were some interaction tests that were disabled as part of the move to ItemsRepeater.
Fix and re-enable them.
ArrowKeyNavigationTest, ArrowKeyHierarchicalNavigationTest, TabNavigationTest, and ScrollToMenuItemTest -> Update downlevel (RS3 and below) arrow and tab navigation to behave as in RS4+, re-enable the tests for these affected versions. Add tabbing state saving behavior so that tabbing into the list focuses the last focused item.
@ojhad ojhad added bug Something isn't working area-NavigationView NavView control labels Jan 8, 2020
@ojhad ojhad self-assigned this Jan 8, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 8, 2020
@ojhad ojhad mentioned this issue Jan 8, 2020
Merged
@kmahone kmahone added team-Controls Issue for the Controls team test issue Issue with test code and removed needs-triage Issue needs to be triaged by the area owners labels Jan 8, 2020
@ojhad ojhad mentioned this issue Jan 15, 2020
Closed
@marcelwgn marcelwgn mentioned this issue Apr 9, 2020
Open
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ojhad ojhad

Labels
area-NavigationView NavView control bug Something isn't working no-issue-activity team-Controls Issue for the Controls team test issue Issue with test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pre-rs3 keyboard navigation for NavigationView microsoft/microsoft-ui-xaml
3 participants
@ojhad @kmahone @msft-github-bot