Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyout submenu should align to its origin menu item #1462

Closed
adrientetar opened this issue Oct 18, 2019 · 8 comments
Closed

MenuFlyout submenu should align to its origin menu item #1462

adrientetar opened this issue Oct 18, 2019 · 8 comments
Labels
area-Menus area-UIDesign UI Design, styling needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Controls Issue for the Controls team

Comments

@adrientetar
Copy link

adrientetar commented Oct 18, 2019

When opening a MenuFlyout submenu, the submenu items should vertically align with the origin menu item. It seems that the padding at the top of MenuFlyout isn't currently accounted for.

Image posted by @chigy in #1445

image

@adrientetar adrientetar changed the title MenuFlyout submenu should align with to its parent menu item MenuFlyout submenu should align to its origin menu item Oct 18, 2019
@jevansaks
Copy link
Member

@chigy should we remove the top/bottom padding on the menu? That would make this easy to solve. :)

@chigy
Copy link
Member

chigy commented Oct 21, 2019

@chigy should we remove the top/bottom padding on the menu? That would make this easy to solve. :)

No, that was already discussed with design and decided they do not want the padding removed.

@jevansaks
Copy link
Member

Hmm ... ok, do you have a comp for what it should look like? @karenbtlai was suggesting that it might look unbalanced/misaligned in other states if we try to shift the flyout position to address this.

@chigy
Copy link
Member

chigy commented Oct 21, 2019

@karenbtlai , Could you explain what the problem might be?

Before
image

After
image

@jevansaks
Copy link
Member

I'm not sure if there's a way to do this with just style/template changes. In theory a negative Margin could do it, but IIRC we used to have that and removed it because of some shadow stuff. Is that right, @kaiguo?

@jevansaks jevansaks added area-Menus area-UIDesign UI Design, styling labels Oct 22, 2019
@jevansaks jevansaks added the needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) label Oct 22, 2019
@kaiguo
Copy link
Contributor

kaiguo commented Oct 22, 2019

I'm not sure if there's a way to do this with just style/template changes. In theory a negative Margin could do it, but IIRC we used to have that and removed it because of some shadow stuff. Is that right, @kaiguo Kai Guo FTE?

I think negative margins were removed because the way we positioning popup changed, and we switched to vertical/horizontal offset instead.

Looks like we don't want to remove the top padding, and don't want to shift flyout position either, what's the suggested change?

@jevansaks
Copy link
Member

don't want to shift flyout position either, what's the suggested change?

I believe @chigy is requesting to change the flyout position. Is that possible in WinUI today?

@jevansaks jevansaks added the team-Controls Issue for the Controls team label Nov 7, 2019
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Menus area-UIDesign UI Design, styling needs-winui-3 Indicates that feature can only be done in WinUI 3.0 or beyond. (needs winui 3) no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants