Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several controls don't meet new non-text contrast ratio requirement #1233

Closed
YuliKl opened this issue Aug 28, 2019 · 5 comments
Closed

Several controls don't meet new non-text contrast ratio requirement #1233

YuliKl opened this issue Aug 28, 2019 · 5 comments
Assignees
Labels
accessibility Narrator, keyboarding, UIA, etc area-UIDesign UI Design, styling team-Controls Issue for the Controls team

Comments

@YuliKl
Copy link

YuliKl commented Aug 28, 2019

Describe the bug

Controls will be required to meet MAS 1.4.11 - Non-text Contrast

Slider

In light theme, the Slider control's grey track presents a contrast ratio of 2.8:1 instead of the required 3:1.

image

Buttons

Button backplates do not meet contrast ratios in either light or dark theme.
image

@YuliKl YuliKl added accessibility Narrator, keyboarding, UIA, etc area-UIDesign UI Design, styling labels Aug 28, 2019
@YuliKl YuliKl changed the title Slider's track color doesn't meet contrast ratio requirement Several controls don't meet new non-text contrast ratio requirement Aug 28, 2019
@mdtauk
Copy link
Contributor

mdtauk commented Aug 29, 2019

Perhaps this is something that could be addressed through Issues #920 and #921 where I suggest another look at Light and Dark Theme colours

@jevansaks
Copy link
Member

@YuliKl do you have a suggestion for how to fix? Are there comps with the updates?

@mdtauk
Copy link
Contributor

mdtauk commented Sep 3, 2019

Any contrast ratio check will differ if the control is not placed on a Pure White (or Pure Black in dark mode) background.

The Outline style would probably fair better for contrast, and using Semibold text for the button text, would also help pass the ratio test at 14 epx and above.

@marcelwgn
Copy link
Collaborator

@YuliKl How could this be fixed? Should we pick a darker gray for the track so we meet the new requirement?

@YuliKl
Copy link
Author

YuliKl commented Sep 18, 2020

Closing this issue. No changes to Button colors are required as clarified in the WCAG 2.1 guidance. I'm not sure that anyone uses sliders with tick marks as I have seen no reports of violations there.

@YuliKl YuliKl closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Narrator, keyboarding, UIA, etc area-UIDesign UI Design, styling team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

4 participants