diff --git a/dev/NavigationView/NavigationView.cpp b/dev/NavigationView/NavigationView.cpp index 6d0c54864d..b26d6f2379 100644 --- a/dev/NavigationView/NavigationView.cpp +++ b/dev/NavigationView/NavigationView.cpp @@ -664,7 +664,6 @@ void NavigationView::OnApplyTemplate() UpdatePaneTabFocusNavigation(); UpdateBackAndCloseButtonsVisibility(); UpdateSingleSelectionFollowsFocusTemplateSetting(); - UpdateNavigationViewUseSystemVisual(); UpdatePaneVisibility(); UpdateVisualState(); UpdatePaneTitleMargins(); @@ -1185,11 +1184,6 @@ void NavigationView::OnRepeaterElementPrepared(const winrt::ItemsRepeater& ir, c }(); winrt::get_self(nvi)->PropagateDepthToChildren(childDepth); - if (ir != m_topNavRepeaterOverflowView.get()) - { - nvibImpl->UseSystemFocusVisuals(ShouldShowFocusVisual()); - } - // Register for item events auto nviRevokers = winrt::make_self(); nviRevokers->tappedRevoker = nvi.Tapped(winrt::auto_revoke, { this, &NavigationView::OnNavigationViewItemTapped }); @@ -3165,45 +3159,6 @@ void NavigationView::UpdateLeftNavigationOnlyVisualState(bool useTransitions) winrt::VisualStateManager::GoToState(*this, isToggleButtonVisible ? L"TogglePaneButtonVisible" : L"TogglePaneButtonCollapsed", false /*useTransitions*/); } -void NavigationView::UpdateNavigationViewUseSystemVisual() -{ - if (SharedHelpers::IsRS1OrHigher() && !ShouldPreserveNavigationViewRS4Behavior() && m_appliedTemplate) - { - PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(m_leftNavRepeater.get(), ShouldShowFocusVisual()); - PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(m_leftNavFooterMenuRepeater.get(), ShouldShowFocusVisual()); - PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(m_topNavRepeater.get(), ShouldShowFocusVisual()); - PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(m_topNavFooterMenuRepeater.get(), ShouldShowFocusVisual()); - } -} - -bool NavigationView::ShouldShowFocusVisual() -{ - return SelectionFollowsFocus() == winrt::NavigationViewSelectionFollowsFocus::Disabled; -} - -void NavigationView::PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(winrt::ItemsRepeater const& ir, bool showFocusVisual) -{ - if (ir) - { - if (auto itemsSourceView = ir.ItemsSourceView()) - { - const auto numberOfItems = itemsSourceView.Count(); - for (int i = 0; i < numberOfItems; i++) - { - if (auto nvib = ir.TryGetElement(i)) - { - if (auto nvi = nvib.try_as()) - { - auto nviImpl = winrt::get_self(nvi); - nviImpl->UseSystemFocusVisuals(showFocusVisual); - } - } - - } - } - } -} - void NavigationView::InvalidateTopNavPrimaryLayout() { if (m_appliedTemplate && IsTopNavigationView()) @@ -3793,7 +3748,6 @@ void NavigationView::OnPropertyChanged(const winrt::DependencyPropertyChangedEve else if (property == s_SelectionFollowsFocusProperty) { UpdateSingleSelectionFollowsFocusTemplateSetting(); - UpdateNavigationViewUseSystemVisual(); } else if (property == s_IsPaneToggleButtonVisibleProperty) { diff --git a/dev/NavigationView/NavigationView.h b/dev/NavigationView/NavigationView.h index 6acbb568a9..2ccd008039 100644 --- a/dev/NavigationView/NavigationView.h +++ b/dev/NavigationView/NavigationView.h @@ -166,8 +166,6 @@ class NavigationView : void UpdateVisualState(bool useTransitions = false); void UpdateVisualStateForOverflowButton(); void UpdateLeftNavigationOnlyVisualState(bool useTransitions); - void UpdateNavigationViewUseSystemVisual(); - static void PropagateShowFocusVisualToAllNavigationViewItemsInRepeater(winrt::ItemsRepeater const& ir, bool showFocusVisual); void UpdatePaneShadow(); void UpdateNavigationViewItemsFactory(); void SyncItemTemplates(); @@ -321,7 +319,6 @@ class NavigationView : bool ShouldPreserveNavigationViewRS3Behavior(); bool NeedRearrangeOfTopElementsAfterOverflowSelectionChanged(int selectedOriginalIndex); - bool ShouldShowFocusVisual(); void KeyboardFocusFirstItemFromItem(const winrt::NavigationViewItemBase& nvib); void KeyboardFocusLastItemFromItem(const winrt::NavigationViewItemBase& nvib); void FocusNextDownItem(const winrt::NavigationViewItem& nvi, const winrt::KeyRoutedEventArgs& args); diff --git a/dev/NavigationView/NavigationView.xaml b/dev/NavigationView/NavigationView.xaml index 6bafd1b481..e32d32a918 100644 --- a/dev/NavigationView/NavigationView.xaml +++ b/dev/NavigationView/NavigationView.xaml @@ -508,10 +508,6 @@ -