Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the top-level activeParameter property or update the documentation to clearly explain why there are two of them #2080

Open
DetachHead opened this issue Jan 9, 2025 · 0 comments

Comments

@DetachHead
Copy link

if i'm understanding the situation correctly (after skimming through microsoft/vscode#94637), it seems that SignatureInformation.activeParameter is supposed to replace the top-level one in textDocument/signatureHelp. but currently there are two of them and the documentation doesn't really explain why. in fact the documentation on the top level one seems to imply the opposite, since it says the following:

In future version of the protocol this property might become mandatory to better express the active parameter if the active signature does have any.

i think either the top-level one should be explicitly marked as deprecated, or the documentation should be updated to clarify which one is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant