-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Request Adapter #364
Comments
To clarify, we don't want the same implementation from our PHP core for Microsoft Graph in Kiota, we want to use our implementation as a reference for adding a generic implementation in Kiota HTTP Core. This is my understanding. Some of these will not be added to the default pipeline. Is it safe to say that the authorization, retry, and redirect handlers can be added to the default middleware pipeline? Please check me. |
You can look at #360 to get more context and experience feedback from the dotnet work on that aspect. I don't think we need an auth middleware anymore given the current architecture for Kiota. The goal is always to put all the non graph specific things in Kiota cores so it's available to others, and keep the graph specific things in Graph core, so we have a good feature set for graph users. In terms of the defaults, I'd argue that most if not all middlewares defined in kiota http core should be part of the defaults, unless you have a specific point? Let me know if that answers most questions here, and don't hesitate to ask follow up questions. |
Notes for future reference:
|
Looking at the sdk-design features list, there are a number of component that exist today in the graph core library which belong to the kiota http core library. Most of those components are the middlewares. If they exist, move the following components:
pipeline(if not provided by the native http client)authorization handlerredirect handler(provided by Guzzle)changes can be specified by a callback)
AB#10329
The text was updated successfully, but these errors were encountered: