From b497608a66fd4873a4b9f6c6b2a2717f113ad20c Mon Sep 17 00:00:00 2001 From: Seth Hollandsworth Date: Wed, 13 Sep 2023 18:48:50 -0400 Subject: [PATCH] defaulting to unbuffered reader for dmverity hashing (#1887) Signed-off-by: Seth Hollandsworth Co-authored-by: ksayid (cherry picked from commit e7509cc6636d89ad8e748bb4c127f83af7131b05) Signed-off-by: Maksim An --- cmd/dmverity-vhd/main.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmd/dmverity-vhd/main.go b/cmd/dmverity-vhd/main.go index 439a750352..0add4a2189 100644 --- a/cmd/dmverity-vhd/main.go +++ b/cmd/dmverity-vhd/main.go @@ -103,7 +103,13 @@ func fetchImageLayers(ctx *cli.Context) (layers []v1.Layer, err error) { // if only an image name is provided and not a tag, the default is "latest" img, err = tarball.ImageFromPath(tarballPath, &imageNameAndTag) } else if dockerDaemon { - img, err = daemon.Image(ref) + // use the unbuffered opener, the tradeoff being the image will stream as needed + // so it is slower but much more memory efficient + var opts []daemon.Option + opt := daemon.WithUnbufferedOpener() + opts = append(opts, opt) + + img, err = daemon.Image(ref, opts...) } else { var remoteOpts []remote.Option if ctx.IsSet(usernameFlag) && ctx.IsSet(passwordFlag) {