Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deobfuscation path visible only if Update Metadata is selected #231

Closed
kkalisz opened this issue Jan 29, 2021 · 4 comments
Closed

Deobfuscation path visible only if Update Metadata is selected #231

kkalisz opened this issue Jan 29, 2021 · 4 comments
Assignees
Labels

Comments

@kkalisz
Copy link

kkalisz commented Jan 29, 2021

Task:
Google Play - Release

Issue:
"Deobfuscation path" field is visible only if "Update metadata" checkbox is set

Expected behaviour:
"Deobfuscation path" visible even without "Update metadata" checkbox set

Investigation:
It looks that visibility rule is fine

{
"name": "mappingFilePath",
"type": "filePath",
"label": "ms-resource:loc.input.label.mappingFilePath",
"defaultValue": "",
"required": false,
"helpMarkDown": "ms-resource:loc.input.help.mappingFilePath",
"visibleRule": "shouldUploadApks = true && shouldUploadMappingFile = true"
}

But I think that issue may be related to this PR 193
as it was directly impacting "shouldUploadApks" element. Unfortunately I'm not familiar with extensions so I'm not able to investigate this further.

image
image

@alexander-smolyakov
Copy link
Contributor

Hey @kkalisz, a PR with the fix was merged. The fix will be shipped with the next release of the extension.

@alexander-smolyakov alexander-smolyakov added the awaiting deployment Related changes are waiting for deployment to be completed label Feb 9, 2021
@liumiaojq
Copy link

@alexander-smolyakov Is there an ETA when this fix is shipped? I have another issue #210 where it fails to find the correct mapping file, and this fix could help to work around by explicitly specifying mapping file path

@anatolybolshakov
Copy link
Contributor

Hey @liumiaojq we are resolving issues with current release version and planning to release it soon - we will let you know once it's available.

@alexander-smolyakov
Copy link
Contributor

@kkalisz, @liumiaojq a release with the fix has been published. I am closing it at the moment, if the problem still appears, feel free to reopen it.

@alexander-smolyakov alexander-smolyakov removed the awaiting deployment Related changes are waiting for deployment to be completed label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants