Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new WOFF files to the @uifabric/icons/fonts folder #3848

Merged
merged 14 commits into from
Jan 31, 2018

Conversation

srideshpande
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: ODSP_next icons issue

Description of changes

Adding new WOFF files to the @uifabric/icons/fonts folder

Copy link
Collaborator

@lynamemi lynamemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe minor version bump since we missed that in the last PR? Not sure - otherwise I checked that the src file reference matches the font names and that each file hits the cdn successfully.

@lynamemi lynamemi merged commit 66a91aa into microsoft:master Jan 31, 2018
gokunymbus added a commit that referenced this pull request Feb 1, 2018
gokunymbus added a commit that referenced this pull request Feb 1, 2018
* Revert "Updating config files in @uifabric/icons package (#3851)"

This reverts commit 952ad79.

* Revert "Addressing Issue #3776 - Sticky component loops forever if background-color is not set for page (#3833)"

This reverts commit ddc5440.

* Revert "Fix issue in modal Selection handling (#3836)"

This reverts commit c304b01.

* Revert "Adding new WOFF files to the @uifabric/icons/fonts folder (#3848)"

This reverts commit 66a91aa.

* Revert "Controlled TextFields (#3796)"

This reverts commit b17a45f.
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this pull request Apr 17, 2018
…3848)

* new line

* Updating icons

* rush change file

* Removing the third party logos from the list of icons being exported

* Updating the names of enum, not to start with a number

* Adding new WOFF files to the @uifabric/icons/fonts folder
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this pull request Apr 17, 2018
* Revert "Updating config files in @uifabric/icons package (microsoft#3851)"

This reverts commit 952ad79.

* Revert "Addressing Issue microsoft#3776 - Sticky component loops forever if background-color is not set for page (microsoft#3833)"

This reverts commit ddc5440.

* Revert "Fix issue in modal Selection handling (microsoft#3836)"

This reverts commit c304b01.

* Revert "Adding new WOFF files to the @uifabric/icons/fonts folder (microsoft#3848)"

This reverts commit 66a91aa.

* Revert "Controlled TextFields (microsoft#3796)"

This reverts commit b17a45f.
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants