-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new WOFF files to the @uifabric/icons/fonts folder #3848
Merged
lynamemi
merged 14 commits into
microsoft:master
from
srideshpande:srideshpande/icon-update
Jan 31, 2018
Merged
Adding new WOFF files to the @uifabric/icons/fonts folder #3848
lynamemi
merged 14 commits into
microsoft:master
from
srideshpande:srideshpande/icon-update
Jan 31, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynamemi
approved these changes
Jan 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe minor version bump since we missed that in the last PR? Not sure - otherwise I checked that the src file reference matches the font names and that each file hits the cdn successfully.
gokunymbus
added a commit
that referenced
this pull request
Feb 1, 2018
)" This reverts commit 66a91aa.
gokunymbus
added a commit
that referenced
this pull request
Feb 1, 2018
* Revert "Updating config files in @uifabric/icons package (#3851)" This reverts commit 952ad79. * Revert "Addressing Issue #3776 - Sticky component loops forever if background-color is not set for page (#3833)" This reverts commit ddc5440. * Revert "Fix issue in modal Selection handling (#3836)" This reverts commit c304b01. * Revert "Adding new WOFF files to the @uifabric/icons/fonts folder (#3848)" This reverts commit 66a91aa. * Revert "Controlled TextFields (#3796)" This reverts commit b17a45f.
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
…3848) * new line * Updating icons * rush change file * Removing the third party logos from the list of icons being exported * Updating the names of enum, not to start with a number * Adding new WOFF files to the @uifabric/icons/fonts folder
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Revert "Updating config files in @uifabric/icons package (microsoft#3851)" This reverts commit 952ad79. * Revert "Addressing Issue microsoft#3776 - Sticky component loops forever if background-color is not set for page (microsoft#3833)" This reverts commit ddc5440. * Revert "Fix issue in modal Selection handling (microsoft#3836)" This reverts commit c304b01. * Revert "Adding new WOFF files to the @uifabric/icons/fonts folder (microsoft#3848)" This reverts commit 66a91aa. * Revert "Controlled TextFields (microsoft#3796)" This reverts commit b17a45f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Adding new WOFF files to the @uifabric/icons/fonts folder