Adding check to DatePicker componentWillReceiveProps to prevent unnecessary validation failures #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannao76
approved these changes
Jan 31, 2018
| @@ -142,6 +142,11 @@ export class DatePicker extends BaseComponent<IDatePickerProps, IDatePickerState | |||
| } | |||
|
|
|||
| public componentWillReceiveProps(nextProps: IDatePickerProps) { | |||
| if (JSON.stringify(this.props) === JSON.stringify(nextProps)) { | |||
There was a problem hiding this comment.
Why do you need to stringify before comparing?
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
…essary validation failures (microsoft#3843) * direct comparison of objects returns false, need to stringify to compare * adding change file * build didn't like ==, changing to === * final fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
DatePicker allows the consumer to pass a prop for the value, and a prop for isRequired. If a consumer changes the properties, it's possible that the required validation step might no longer be passing, so DatePicker was running validation during WillReceiveProps. However, it ran this regardless of whether the props actually changed, so the parent rerendering was causing validation to fail even without ever focusing the component. Here we add a quick check to make sure the serializable props actually changed before running that validation.
Focus areas to test
(optional)