ContextualMenu: Remove the list inside the menu and move aria labeling to the correct element #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dby should be on the menu
christiango
approved these changes
Jan 30, 2018
joschect
approved these changes
Jan 30, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
…g to the correct element (microsoft#3838) * Contextual Menus should not contain a list and the aria-label/labelledby should be on the menu * rush change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The child of the menu was incorrectly showing up in the UIA tree as a list. Upon investigating, the list items of the list had already been changed to role=presentation, but the ul list element had not yet been updated.
This change marks role=presentation on the list (ul) element and moves the aria-label/labelledby to the correct role=menu element
Focus areas to test
Verified that the menu is no longer reporting as a list and the labelling is hooked up to the correct element