Fixing Picker suggestions RTL alignment #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
reviewed
Jan 24, 2018
| @@ -230,7 +230,8 @@ export class BasePicker<T, P extends IBasePickerProps<T>> extends BaseComponent< | |||
| gapSpace={ 5 } | |||
| target={ this.input.inputElement } | |||
| onDismiss={ this.dismissSuggestions } | |||
| directionalHint={ getRTL() ? DirectionalHint.bottomRightEdge : DirectionalHint.bottomLeftEdge } | |||
There was a problem hiding this comment.
Remove the getRTL import.
There was a problem hiding this comment.
Great catch. It's removed now.
joschect
approved these changes
Jan 24, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Making picker suggestions callout align to correct rtl position * rush change * Removing getRTL import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Just setting directionalHint based on getRTL wasn't working, so this PR sets directionalHint and directionalHintForRTL to put the suggestions in the right spot.