Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor README.md update for styling #3768

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Minor README.md update for styling #3768

merged 1 commit into from
Jan 25, 2018

Conversation

Jahnp
Copy link
Member

@Jahnp Jahnp commented Jan 23, 2018

Pull request checklist

Description of changes

Fixes a minor docs bug with the @uifabric/styling README. colors should instead be palette. See the value of the object returned from createTheme here for an example of what I mean.

Fixes a minor docs bug with the `@uifabric/styling` README. `colors` should instead be `palette`. See the value of the object returned from `createTheme` [here](https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/styling/src/styles/theme.ts#L107) for an example of what I mean.
@dzearing dzearing merged commit 1da9cd3 into master Jan 25, 2018
@dzearing dzearing deleted the jahnp/styling-docs-fix branch January 25, 2018 03:28
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this pull request Apr 17, 2018
Fixes a minor docs bug with the `@uifabric/styling` README. `colors` should instead be `palette`. See the value of the object returned from `createTheme` [here](https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/styling/src/styles/theme.ts#L107) for an example of what I mean.
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in the documentation for overwriting theme colors
2 participants