TextField & SearchBox: Specified placeholder colors #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phkuo
reviewed
Jan 23, 2018
| @@ -11,7 +11,7 @@ import { ISearchBoxProps, ISearchBoxStyleProps, ISearchBoxStyles } from './Searc | |||
|
|
|||
| export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles { | |||
| const { theme, underlined, disabled, hasFocus, className, hasInput } = props; | |||
| const { palette, fonts } = theme; | |||
| const { palette, fonts, semanticColors } = theme; | |||
There was a problem hiding this comment.
shouldn't you get a compiler warning for adding semanticColors here but not use it?
There was a problem hiding this comment.
true! I just added the slot for inputPlaceholderText.
phkuo
reviewed
Jan 23, 2018
| @@ -142,6 +142,16 @@ export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles { | |||
| selectors: { | |||
| '::-ms-clear': { | |||
| display: 'none' | |||
| }, | |||
| '::placeholder': { | |||
| color: palette.neutralSecondary, | |||
There was a problem hiding this comment.
we should add an inputPlaceholderText slot
phkuo
approved these changes
Jan 23, 2018
| ':-ms-input-placeholder': { | ||
| color: palette.neutralSecondary | ||
| }, | ||
| '::-ms-input-placeholder': { |
There was a problem hiding this comment.
are both syntaxes necessary?
There was a problem hiding this comment.
Apparently browser versioning and placeholder selectors get hairy, but it looks like using just the two will work on at at least all my browser versions.
micahgodbolt
approved these changes
Jan 23, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Searchbox and textfield neutral secondary placeholder text * Using the palette * Added change file * New slot for inputPlaceholderText * Semantic slots in styles * style change file * Minor bump * Searchbox snapshot update
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Allows us to be consistent across browsers
Focus areas to test
(optional)