Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageBar: New prop for text truncation with singleline text #3751

Merged
merged 14 commits into from
Jan 20, 2018
Merged

MessageBar: New prop for text truncation with singleline text #3751

merged 14 commits into from
Jan 20, 2018

Conversation

lynamemi
Copy link
Collaborator

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

  • New prop that, when true, adds a double chevron icon button that, when clicked, shows and hides truncated text. Only available for singleline MessageBars with no action buttons.
  • Also refined oneline/singleline verbage to just be singleline for consistency.

message bar truncation

Focus areas to test

(optional)

@dzearing dzearing merged commit f381105 into microsoft:master Jan 20, 2018
@emilenriquez
Copy link

has this been released?

@lynamemi
Copy link
Collaborator Author

lynamemi commented Mar 2, 2018

Yes - you can see an example of it on the website:
https://developer.microsoft.com/en-us/fabric#/components/messagebar

@lynamemi lynamemi deleted the message-bar branch March 2, 2018 22:52
@emilenriquez
Copy link

thanks!~

chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this pull request Apr 17, 2018
@lynamemi
MessageBar: New prop for text truncation with singleline text (micros…
102810b 
…oft#3751)

* Basic truncated message bar variant

* Removed comment

* hasOverflow implemented, still need to resolve conflict with DelayedRender

* Refactored naming for consistency and changing text overflow on click. Reinstating truncated prop.

* More case consistency

* Updated examples

* Added tests

* Revised example text

* New class for mobile to expand instead of wrap

* Added change file

* Updating dismiss icon to Clear icon per toolkit

* Change dismiss and expand icon color
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikewheaton mikewheaton mikewheaton approved these changes

@justinmwarner justinmwarner Awaiting requested review from justinmwarner

@betrue-final-final betrue-final-final Awaiting requested review from betrue-final-final

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lynamemi @emilenriquez @mikewheaton @dzearing