Picker header #3737
Merged
Picker header #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
reviewed
Jan 18, 2018
| /> | ||
| ); | ||
| } | ||
|
|
||
| private _renderHeader(): JSX.Element { | ||
| return <div>TO:</div>; |
There was a problem hiding this comment.
Did you intend for this to just be TO:?
There was a problem hiding this comment.
Since this is just the example, yes this was just a simple element, to demonstrate an element rendering before the selected contents. I can make this more robust if you prefer.
There was a problem hiding this comment.
Oh shoot! I completely missed that it was an example, disregard my comment.
There was a problem hiding this comment.
@joschect did you have any other comments?
joschect
approved these changes
Jan 24, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* add header element, fix css styling for items and input * add change file * fix tslint errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes