[SearchBox] onChange and flex layout fix for IE #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phkuo
reviewed
Jan 17, 2018
| @@ -133,7 +133,9 @@ export function getStyles(props: ISearchBoxStyleProps): ISearchBoxStyles { | |||
| fontSize: 'inherit', | |||
| color: palette.neutralPrimary, | |||
| backgroundColor: 'transparent', | |||
| flex: '1 1 0', | |||
| flexBasis: 0, | |||
There was a problem hiding this comment.
why change this? it's more bytes-over-wire
There was a problem hiding this comment.
I changed it because IE didn't support this shorthand format:
flex: '1 1 0'
flex: '1 1 0px' does work, however. I've updated the branch.
BTW: This fixes an issue where the clear button is incorrectly positioned:
There was a problem hiding this comment.
Ah, good to know we need the px on the flex-basis part no matter what, thanks for catching that.
phkuo
approved these changes
Jan 18, 2018
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* [SearchBox] onChange and flex layout fix for IE * [SearchBox] Use flex shorthand
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes two things for the SearchBox when running on IE: