remove customized dismiss function in hover card #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
reviewed
Dec 1, 2017
| @@ -47,4 +47,10 @@ export interface IFocusTrapZoneProps extends React.HTMLAttributes<HTMLDivElement | |||
| * Indicates the selector for first focusable item | |||
| */ | |||
| firstFocusableSelector?: string | (() => string); | |||
|
|
|||
| /** | |||
| * Disable focus onto first element when render focus trap zone | |||
ThomasMichon
approved these changes
Dec 4, 2017
2 tasks
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* remove customized dismiss function in hover card * rush change * add ref in tile component * rush change in experiments * change comments * change hot key for hover card to "c"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Remove customized dismiss function in hover card, let callout component handle it
Focus areas to test
(optional)