Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Fix listText semantic slot name #3403

Merged
merged 3 commits into from
Jan 20, 2018
Merged

Theming: Fix listText semantic slot name #3403

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21a7abd
fix colors
phkuo Nov 16, 2017
ec627f4
change file
phkuo Nov 16, 2017
7525d0e
deprecate slots correctly
phkuo Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/styling/phkuo-fixListText_2017-11-16-03-20.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/styling",
"comment": "Theming: fix listText semantic slot",
"type": "patch"
}
],
"packageName": "@uifabric/styling",
"email": "phkuo@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/styling/src/interfaces/ISemanticColors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export interface ISemanticColors {
/**
* The default text color for list item titles and text in column fields.
*/
listTextColor: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you deprecate colors? and keep them the old value and not use them?

listText: string;

/**
* The background color of a hovered list item.
Expand Down
2 changes: 1 addition & 1 deletion packages/styling/src/styles/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function _makeSemanticColorsFromPalette(p: IPalette, isInverted: boolean): ISema
menuHeader: p.themePrimary,

listBackground: p.white,
listTextColor: p.neutralPrimary,
listText: p.neutralPrimary,
listItemBackgroundHovered: p.neutralLighter,
listItemBackgroundChecked: p.neutralLight,
listItemBackgroundCheckedHovered: p.neutralQuaternaryAlt
Expand Down