Theming: Fix listText semantic slot name #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
reviewed
Nov 16, 2017
| @@ -238,7 +238,7 @@ export interface ISemanticColors { | |||
| /** | |||
| * The default text color for list item titles and text in column fields. | |||
| */ | |||
| listTextColor: string; | |||
There was a problem hiding this comment.
Can you deprecate colors? and keep them the old value and not use them?
dzearing
previously requested changes
Nov 16, 2017
|
@dzearing fixed your comments, please re-review |
dzearing
reviewed
Dec 1, 2017
| @@ -481,7 +481,7 @@ export class ThemeGeneratorPage extends BaseComponent<any, IThemeGeneratorPageSt | |||
| } | |||
| document.body.style.backgroundColor = themeAsJson.backgroundColor; | |||
| document.body.style.color = themeAsJson.bodyText; | |||
| loadTheme({ palette: themeAsJson }); | |||
| console.log('Full theme... ', loadTheme({ palette: themeAsJson })); | |||
There was a problem hiding this comment.
Yes, just better logging.
|
@dzearing poke |
joschect
reviewed
Jan 12, 2018
| } | ||
|
|
||
| function _fixDeprecatedSlots(s: ISemanticColors): ISemanticColors { | ||
| s.listTextColor = s.listText; |
There was a problem hiding this comment.
What if the user passed in their own listTextColor but didn't pass in listText
There was a problem hiding this comment.
that's fine, they'd get a customized listTextColor but not a customized listText, as intended. hmm, i guess i could do it the other way and say listText: p.listTextColor || p.neutralPrimary........
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* fix colors * change file * deprecate slots correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Fix incorrect naming convention for the listText semantic slot which is not theming right now because it is incorrectly named.
Added framework for "deprecating" semantic slots.
Focus areas to test
(optional)