Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Add button focus swap example #1733

Merged
merged 4 commits into from
May 10, 2017

Conversation

hross
Copy link
Contributor

@hross hross commented May 5, 2017

Pull request checklist

Description of changes

Added an example of swapping buttons and keeping track of focus, since swapping primary/default causes focus loss on control change.

@hross hross requested a review from cschleiden May 5, 2017 17:48
@hross hross changed the title Add button focus swap example Button: Add button focus swap example May 5, 2017
@micahgodbolt
Copy link
Member

Can you drop in a quick animated gif of what this looks like in the documentation?

@hross
Copy link
Contributor Author

hross commented May 8, 2017

@micahgodbolt I'm not sure where you mean about where to put the gif, but I've attached it here:

swap_button

@micahgodbolt
Copy link
Member

@hross yup! dropping a quick image into github saves many git clones :)

@hross hross requested a review from micahgodbolt May 8, 2017 19:45
@hross hross merged commit dbe7899 into microsoft:master May 10, 2017
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we have a generic "button" component back? Or a pared down version?
4 participants