Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnifiedPicker: Don't show picker after input is cleared #16937

Merged
merged 2 commits into from
Feb 11, 2021
Merged

UnifiedPicker: Don't show picker after input is cleared #16937

merged 2 commits into from
Feb 11, 2021

Conversation

elisabethcvs
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

If the picker is already hidden and the query string is empty, don't show the picker

@elisabethcvs elisabethcvs mentioned this pull request Feb 10, 2021
Merged
2 tasks
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4278116:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 10, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cadc0c0873697c2ad1139d8fcd5ffc58ed049606 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

Scenario Render type Master Ticks PR Ticks Iterations Status
buttonNative mount 105 111 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 784 820 5000
BaseButton mount 854 871 5000
Breadcrumb mount 41694 41347 5000
ButtonNext mount 645 640 5000
Checkbox mount 1396 1434 5000
CheckboxBase mount 1187 1195 5000
ChoiceGroup mount 4511 4545 5000
ComboBox mount 964 926 1000
CommandBar mount 9674 9635 1000
ContextualMenu mount 5887 5881 1000
DefaultButton mount 1073 1079 5000
DetailsRow mount 3442 3531 5000
DetailsRowFast mount 3418 3467 5000
DetailsRowNoStyles mount 3326 3268 5000
Dialog mount 1403 1382 1000
DocumentCardTitle mount 1776 1795 1000
Dropdown mount 3164 3154 5000
FocusTrapZone mount 1710 1699 5000
FocusZone mount 1696 1726 5000
IconButton mount 1681 1671 5000
Label mount 313 319 5000
Layer mount 1693 1669 5000
Link mount 437 438 5000
MakeStyles mount 1883 1857 50000
MenuButton mount 1427 1434 5000
MessageBar mount 1942 1942 5000
Nav mount 3107 3045 1000
OverflowSet mount 995 977 5000
Panel mount 1367 1336 1000
Persona mount 836 847 1000
Pivot mount 1343 1329 1000
PrimaryButton mount 1243 1264 5000
Rating mount 7095 7093 5000
SearchBox mount 1246 1251 5000
Shimmer mount 2374 2431 5000
Slider mount 1838 1807 5000
SpinButton mount 4773 4841 5000
Spinner mount 383 393 5000
SplitButton mount 3013 3015 5000
Stack mount 479 477 5000
StackWithIntrinsicChildren mount 1449 1462 5000
StackWithTextChildren mount 4225 4202 5000
SwatchColorPicker mount 9864 9739 5000
Tabs mount 1341 1352 1000
TagPicker mount 2697 2690 5000
TeachingBubble mount 11240 11250 5000
Text mount 396 381 5000
TextField mount 1320 1311 5000
ThemeProvider mount 1405 1401 5000
ThemeProvider virtual-rerender 586 580 5000
ThemeProviderNext mount 2088 2122 5000
Toggle mount 778 761 5000
buttonNative mount 105 111 5000 Possible regression

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.51 0.33:1 2000 340
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 536
🔧 Checkbox.Fluent 0.63 0.34 1.85:1 1000 629
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 778
🔧 Dropdown.Fluent 3 0.38 7.89:1 1000 3000
🔧 Icon.Fluent 0.13 0.06 2.17:1 5000 654
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 414
🔧 Slider.Fluent 1.54 0.42 3.67:1 1000 1537
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 358
🦄 Tooltip.Fluent 0.11 0.87 0.13:1 5000 563

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 212 191 1.11:1
Image.Fluent 414 375 1.1:1
TreeMinimalPerf.default 814 768 1.06:1
MenuMinimalPerf.default 896 855 1.05:1
PortalMinimalPerf.default 164 156 1.05:1
ButtonUseCssPerf.default 826 798 1.04:1
ChatMinimalPerf.default 618 592 1.04:1
ImageMinimalPerf.default 394 379 1.04:1
RadioGroupMinimalPerf.default 451 432 1.04:1
SkeletonMinimalPerf.default 385 371 1.04:1
TableMinimalPerf.default 433 416 1.04:1
AttachmentSlotsPerf.default 1181 1149 1.03:1
ButtonMinimalPerf.default 173 168 1.03:1
ChatDuplicateMessagesPerf.default 376 365 1.03:1
DropdownManyItemsPerf.default 715 697 1.03:1
LabelMinimalPerf.default 421 407 1.03:1
ToolbarMinimalPerf.default 988 960 1.03:1
ButtonSlotsPerf.default 566 554 1.02:1
CarouselMinimalPerf.default 483 475 1.02:1
DropdownMinimalPerf.default 2995 2943 1.02:1
InputMinimalPerf.default 1272 1244 1.02:1
LayoutMinimalPerf.default 410 401 1.02:1
PopupMinimalPerf.default 691 677 1.02:1
ProviderMinimalPerf.default 929 909 1.02:1
RefMinimalPerf.default 246 241 1.02:1
SegmentMinimalPerf.default 371 363 1.02:1
SplitButtonMinimalPerf.default 3744 3653 1.02:1
TooltipMinimalPerf.default 834 815 1.02:1
Avatar.Fluent 340 334 1.02:1
Dialog.Fluent 778 764 1.02:1
AttachmentMinimalPerf.default 168 167 1.01:1
BoxMinimalPerf.default 361 359 1.01:1
ButtonOverridesMissPerf.default 1632 1619 1.01:1
ButtonUseCssNestingPerf.default 1071 1058 1.01:1
CardMinimalPerf.default 550 544 1.01:1
DatepickerMinimalPerf.default 44546 44071 1.01:1
FormMinimalPerf.default 421 416 1.01:1
GridMinimalPerf.default 344 342 1.01:1
HeaderMinimalPerf.default 384 382 1.01:1
HeaderSlotsPerf.default 761 756 1.01:1
ItemLayoutMinimalPerf.default 1199 1189 1.01:1
ListWith60ListItems.default 619 615 1.01:1
MenuButtonMinimalPerf.default 1553 1541 1.01:1
StatusMinimalPerf.default 705 695 1.01:1
IconMinimalPerf.default 664 660 1.01:1
TableManyItemsPerf.default 1989 1960 1.01:1
TextMinimalPerf.default 371 366 1.01:1
Dropdown.Fluent 3000 2965 1.01:1
ChatWithPopoverPerf.default 427 426 1:1
CheckboxMinimalPerf.default 2766 2762 1:1
DialogMinimalPerf.default 762 762 1:1
DividerMinimalPerf.default 371 372 1:1
EmbedMinimalPerf.default 4152 4151 1:1
ListCommonPerf.default 626 624 1:1
ListMinimalPerf.default 498 499 1:1
LoaderMinimalPerf.default 710 711 1:1
ProviderMergeThemesPerf.default 1579 1579 1:1
ReactionMinimalPerf.default 409 407 1:1
SliderMinimalPerf.default 1574 1572 1:1
TreeWith60ListItems.default 171 171 1:1
VideoMinimalPerf.default 629 630 1:1
Checkbox.Fluent 629 630 1:1
Tooltip.Fluent 563 561 1:1
AnimationMinimalPerf.default 413 419 0.99:1
CustomToolbarPrototype.default 3632 3654 0.99:1
Slider.Fluent 1537 1548 0.99:1
FlexMinimalPerf.default 293 299 0.98:1
ListNestedPerf.default 542 552 0.98:1
Text.Fluent 358 365 0.98:1
TextAreaMinimalPerf.default 459 471 0.97:1
AccordionMinimalPerf.default 159 165 0.96:1
Icon.Fluent 654 681 0.96:1
Button.Fluent 536 562 0.95:1
RosterPerf.default 1095 1205 0.91:1
AlertMinimalPerf.default 283 315 0.9:1

@elisabethcvs elisabethcvs merged commit 4e3e437 into microsoft:master Feb 11, 2021
@elisabethcvs elisabethcvs deleted the pickerpopupfix branch February 11, 2021 17:25
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-experiments@v8.0.0-beta.58 has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@elisabethcvs @joshualamusga1
UnifiedPicker: Don't show picker after input is cleared (microsoft#16937
26ea4e4 
)

* add empty check

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniagonzalez aniagonzalez aniagonzalez approved these changes

Assignees

@joschect joschect

Labels
Component: UnifiedPicker Package: experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elisabethcvs @fabricteam @msft-fluent-ui-bot @aniagonzalez @joschect