Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0: UnifiedPicker: Don't show picker after input is cleared #16936

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

elisabethcvs
Copy link
Contributor

@elisabethcvs elisabethcvs commented Feb 10, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

v8 - #16937

If the picker is already hidden and the query string is empty, don't show the picker

@msft-fluent-ui-bot msft-fluent-ui-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 10, 2021
@elisabethcvs elisabethcvs removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 10, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 57f22e2:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 10, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4a612da69e0b56a616147490d2de9ba87351fb60 (build)

@elisabethcvs elisabethcvs merged commit 2740dab into microsoft:7.0 Feb 11, 2021
@elisabethcvs elisabethcvs deleted the pickerpopupfix7.0 branch February 11, 2021 17:26
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/experiments@v7.38.14 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants