Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] PeoplePicker doesn't have focus border when focused by keyboard #999

Closed
ipip2005 opened this issue Feb 14, 2017 · 2 comments · Fixed by #3774
Closed

[Accessibility] PeoplePicker doesn't have focus border when focused by keyboard #999

ipip2005 opened this issue Feb 14, 2017 · 2 comments · Fixed by #3774
Assignees
@oengusmacinog-zz
Labels
Area: Accessibility Needs: Discussion Type: Bug 🐛

Comments

@ipip2005
Copy link
Contributor

Bug Report

  • Package version(s): latest
  • Browser and OS versions: any

Describe the issue:

The PeoplePicker control doesn't have focus border when TAB focused by keyboard.

Actual behavior:

No focus border

Expected behavior:

A focus border around the box.

If applicable, please provide a codepen repro:

https://fabricreact.azurewebsites.net/fabric-react/master/#/examples/PeoplePicker
@micahgodbolt
Copy link
Member

Current experience is that "focused" item has dark background. Is focus border expected instead?

image

@ipip2005
Copy link
Contributor Author

The focus border I meant is actually the border of the input box.
Like I saw in TextField:

image

@aleksandrjPersonal aleksandrjPersonal self-assigned this Mar 9, 2017
@oengusmacinog-zz oengusmacinog-zz mentioned this issue Jan 23, 2018
Merged
2 tasks
oengusmacinog-zz pushed a commit that referenced this issue Jan 24, 2018
Addressing Issue #999 - [Accessibility] PeoplePicker doesn't have foc…
bd19b42 
…us border when focused by keyboard (#3774)

* added onFocus to BasePicker state and added a control class to input container & Updated Snapshot and Rush Changelog
chrismohr pushed a commit to chrismohr/office-ui-fabric-react that referenced this issue Apr 17, 2018
Addressing Issue microsoft#999 - [Accessibility] PeoplePicker doesn't…
c46eb1f 
… have focus border when focused by keyboard (microsoft#3774)

* added onFocus to BasePicker state and added a control class to input container & Updated Snapshot and Rush Changelog
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@oengusmacinog-zz oengusmacinog-zz

Labels
Area: Accessibility Needs: Discussion Type: Bug 🐛
Projects
None yet
Milestone
No milestone
4 participants
@micahgodbolt @oengusmacinog-zz @aleksandrjPersonal @ipip2005