-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add underline style for DatePicker and Dropdown #5631
Comments
Can you give a bit more information about this issue/change? Do you have designs? Is this a new component? |
Please refer to the TextField component. <Box>
<TextField label="Standard TextField" />
<TextField label="Underlined TextField" underlined />
<DatePicker label="Standard DatePicker" />
<DatePicker label="Underlined DatePicker" underlined />
</Box> |
Yeah, that totally makes sense. All of our pickers are capable of taking a styles object/function, which should allow you to customize them today (which would unblock you if you needed it now). Otherwise, this is a good feature request and we can put it on our backlog. |
For reference, we might look at using the textfield for both datepicker, dropdown, combobox so that we don't have to duplicate styles. Or at least abstracted out some basic textfield that each of the 4 components can use |
Hi I was looking for BasePicker with underlined so it could have the same look and feel when using it with underlined TextField. I guess it would make sense to have AutoFill to use TextField underneath |
@betrue-final-final does the design language of the textfield line up with pickers etc? They are currently using Autofill, which uses a standard tag. Would be interesting to see what it'd look like replacing that with and all of the duplicate functionality that's probably already been written. @joschect - have you looked into this at all? It'd be great if all the pickers had access to the same styles. I know was just converted to css-in-js so that should make it a bit easier to customize. |
Just for reference, here's another request for the underlined style on DatePicker (and others) @betrue-final-final. Issue #5032 also requests an underlined style for DatePicker. I have a PR open for that here, but would still like to discuss it with design before moving forward: #6144. |
I am looking forward to this revision |
We actually have this design pattern in SharePoint already so I would follow that design. @natalieethell, we can discuss in person. |
The underline style has been added for DatePicker (#6144) and we'll put the others on the backlog as they're a larger ticket item. |
this work will definitely be done in dropdown/combobox if/when we move forward with #6030 |
good job! |
I'm not sure whether to open a new issue or just add it here, so I just do the latter: |
Closing in favor of #11345. |
Add underline style for DatePicker and Dropdown as the TextField component
The text was updated successfully, but these errors were encountered: