Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: Keyboard focus is not visible on the "Go to Today," "Next month" and "Previous month" buttons #4619

Closed
edsirko opened this issue Apr 19, 2018 · 3 comments
Assignees

Comments

@edsirko
Copy link

edsirko commented Apr 19, 2018

Bug Report

  • Package version(s): Repro'd in 5.79.1 and 5.46.0, but NOT in 5.39.1
  • Browser and OS versions: Chrome, probably all browsers

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? (No)

Requested priority: (High)

Products/sites affected: (VSTS)

Describe the issue:

When keyboard-navigating the DatePicker, if you focus the "Go to today" button or the up/down arrows to change months (or years), the buttons should be outlined to indicate focus. This seems to have been a regression between 5.39.1 and 5.46.0.

Actual behavior:

They are not outlined to indicate focus.

Expected behavior:

The buttons should be outlined to indicate focus.

If applicable, please provide a codepen repro:

@KevinTCoughlin
Copy link
Member

Can confirm repro on Fabric example site. Might be related to the same commit as #4620.

Thanks again for the report @edsirko. We'll get this fixed.

@KevinTCoughlin
Copy link
Member

KevinTCoughlin commented Apr 24, 2018

It looks like this PR fixed the focus styles -- #4643

@KevinTCoughlin
Copy link
Member

Closing as I can confirm there are focus styles in master. Thanks for the fix @lorejoh12!

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants