Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the documentation for overwriting theme colors #3305

Closed
VinozzZ opened this issue Nov 3, 2017 · 1 comment · Fixed by #3768
Closed

Error in the documentation for overwriting theme colors #3305

VinozzZ opened this issue Nov 3, 2017 · 1 comment · Fixed by #3768
Assignees

Comments

@VinozzZ
Copy link

VinozzZ commented Nov 3, 2017

Bug Report

  • Package version(s): 5.9
  • Browser and OS versions: chrome

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Products/sites affected: (if applicable)

Describe the issue:

The documentation on the github is different from the one on the website

Actual behavior:

import { loadTheme } from 'office-ui-fabric-react/lib/Styling';

loadTheme({
colors: {
themePrimary: 'red'
}
});

Expected behavior:

import { loadTheme } from 'office-ui-fabric-react/lib/Styling';

loadTheme({
palette: {
'themePrimary': 'red'
}
});

@Jahnp
Copy link
Member

Jahnp commented Jan 23, 2018

Thanks for reporting this @VinozzZ. I've opened #3768 to address this.

@Jahnp Jahnp self-assigned this Jan 23, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants