Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox aria-activedescendant should update as you arrow up/down the list, not after you commit the change #3063

Closed
metapzl opened this issue Oct 6, 2017 · 4 comments
Assignees

Comments

@metapzl
Copy link

metapzl commented Oct 6, 2017

Bug Report

  • Package version(s): 5.50

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Products/sites affected: Anyone using Combobox for accessibility

Describe the issue:

Open Combobox, arrow key up/down. It is easier to see the problem when you use Narrator on Edge.

Actual behavior:

The blue bounding box of Narrator stays in the text input box and doesn't follow the dropdown's arrow keys. Also, Narrator does not read the 'selected' item.

Expected behavior:

Narrator's blue box should follow the arrow keys, and Narrator should naturally read the 'selected' item.

If applicable, please provide a codepen repro:

Just use the Fabric example site.

@metapzl
Copy link
Author

metapzl commented Oct 6, 2017

My proposed fix changes

 aria-activedescendant={ (isOpen && (selectedIndex as number) >= 0 ? (id + '-list' + selectedIndex) : null) }

into

aria-activedescendant={
          isOpen &&
          (this.state.currentPendingValueValidIndex as number) >= 0
            ? id + "-list" + this.state.currentPendingValueValidIndex
            : null
        }

@amyngu
Copy link
Contributor

amyngu commented Nov 14, 2017

@jspurlin if you don't have bandwidth to fix this, I can go ahead and take it.

@dzearing for FYI

@jspurlin
Copy link
Contributor

@amyngu , yes feel free to make the fix for this

@jspurlin
Copy link
Contributor

This was fixed by PR: #3738

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants