Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: react-jsx-runtime@9.0.5 missing some types (.d.ts) files #29086

Closed
2 tasks done
sysofwan opened this issue Sep 6, 2023 · 1 comment · Fixed by #29092
Closed
2 tasks done

[Bug]: react-jsx-runtime@9.0.5 missing some types (.d.ts) files #29086

sysofwan opened this issue Sep 6, 2023 · 1 comment · Fixed by #29092
Assignees
Labels
Fluent UI react-components (v9) Shield: P1 Shield developers rate the issue as a high priority (good issue) Status: In PR

Comments

@sysofwan
Copy link
Contributor

sysofwan commented Sep 6, 2023

Library

React Components / v9 (@fluentui/react-components)

System Info

System:                         
    OS: Windows 10 10.0.22621
    CPU: (28) x64 Intel(R) Core(TM) i9-10940X CPU @ 3.30GHz
    Memory: 33.41 GB / 63.80 GB
  Browsers:
    Edge: Spartan (44.22621.2134.0), Chromium (115.0.1901.203)
    Internet Explorer: 11.0.22621.1

Are you reporting Accessibility issue?

None

Reproduction

https://codesandbox.io/p/sandbox/smoosh-wildflower-7mvr6h

Bug Description

Actual Behavior

Compiling with @fluentui/react-jsx-runtime using jsxImportSource following the README results in a compile error.

Could not find a declaration file for module
@fluentui/react-jsx-runtime/jsx-runtime. 
node_modules/@fluentui/react-jsx-runtime/lib/jsx-runtime.js implicitly has an 'any' type.
 
Try `npm i --save-dev @types/fluentui__react-jsx-runtime` if it exists
or add a new declaration (.d.ts) file containing
`declare module '@fluentui/react-jsx-runtime/jsx-runtime'`

Looking at the package files, some files declared in the exports field (./dist/jsx-dev-runtime.d.ts and ./dist/jsx-runtime.d.ts) are missing:

Exports field:
image

Package files:
image

Expected Behavior

./dist/jsx-dev-runtime.d.ts and ./dist/jsx-runtime.d.ts should be included in the published package.

Logs

No response

Requested priority

Normal

Products/sites affected

Microsoft Defender, Microsoft Purview

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@TristanWatanabe
Copy link
Member

Can confirm this to be an issue, on the latest version of the package, we aren't shipping either jsx-dev-runtime.d.ts or jsx-runtime.d.ts files

https://unpkg.com/browse/@fluentui/react-jsx-runtime@9.0.6/dist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-components (v9) Shield: P1 Shield developers rate the issue as a high priority (good issue) Status: In PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants