You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
react v. 16
@fluentui/react v. 8.101.2
Stack in @fluentui/react version 8.101.2 changed to rendering falsy elements instead of returning null.
This change caused many zeroes to appear in Stack's children that were zeroes but consumers were expecting them to be nulled by Stack. This is a breaking change on our side as consumers.Here is a codepen demonstrating the behavior expected in 8.101.1https://codepen.io/ghadnani/pen/oNJXMBLAnd here is a codepen demonstrating the breaking change in 8.101.2https://codepen.io/ghadnani/pen/mdaJjRw
ghadnani
changed the title
[Bug]: Stack in @fluentui/react version 8.101.2 changed to rendering falsy elements instead of returning null. This caused many zeroes to appear in Stack's children that were zeroes and expected to be nulled by Stack.
[Bug]: Stack in @fluentui/react version 8.101.2 changed to rendering falsy elements instead of returning null. This change caused many zeroes to appear in Stack's children that were zeroes expected to be nulled by Stack.
Aug 24, 2023
micahgodbolt
changed the title
[Bug]: Stack in @fluentui/react version 8.101.2 changed to rendering falsy elements instead of returning null. This change caused many zeroes to appear in Stack's children that were zeroes expected to be nulled by Stack.
[Bug]: Stack in @fluentui/react version 8.101.2 changed to rendering falsy elements instead of returning null causes zeros to render
Aug 24, 2023
To give more clarification, this was done so in case you want to render something like a list of numbers where 0 is valid. The previous behavior is actually a bug.
Library
React / v8 (@fluentui/react)
System Info
Expected:

Rendered:

Are you reporting Accessibility issue?
None
Reproduction
https://codepen.io/ghadnani/pen/mdaJjRw
Bug Description
Actual Behavior
Zeroes and other falsy elements changed to being rendered by Stack.
Expected Behavior
Zeroes and other falsy elements to continue being nulled out by Stack.
Logs
No response
Requested priority
Normal
Products/sites affected
AMC (account.microsoft.com)
Are you willing to submit a PR to fix?
no
Validations
The text was updated successfully, but these errors were encountered: