Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckboxIndeterminateCombo #15305

Closed
jwworth opened this issue Sep 29, 2020 · 2 comments
Closed

Add CheckboxIndeterminateCombo #15305

jwworth opened this issue Sep 29, 2020 · 2 comments
Assignees
Labels
Area: Icons Needs: Investigation The Shield Dev should investigate this issue and propose a fix Resolution: Soft Close Soft closing inactive issues over a certain period

Comments

@jwworth
Copy link

jwworth commented Sep 29, 2020

Describe the feature that you would like added

https://uifabricicons.azurewebsites.net/ describes an icon called CheckboxIndeterminateCombo, a partially-filled checkbox. It is not being exported currently by the react-icons package. Adding it would complete a group of three states: partially-filled, filled (CheckboxFillIcon), and not filled (CheckboxIcon).

What component or utility would this be added to

react-icons

Have you discussed this feature with our team, and if so, who

No.

Additional context/screenshots

None. Thank you!

@JustSlone JustSlone added Needs: Investigation The Shield Dev should investigate this issue and propose a fix Area: Icons and removed Needs: Triage 🔍 labels Sep 29, 2020
@JustSlone
Copy link
Collaborator

@jwworth Thanks for pointing this out. It looks like that icon is also missing from our set of Font based icons as well. https://developer.microsoft.com/en-us/fluentui#/styles/web/icons#fabric-react

Here's a codepen with a repro using FontIcon:
https://codepen.io/justslone-the-encoder/pen/LYNoZxv?editors=1010
image

@tomi-msft is working on updating our Icon sets including @fluentui/react-icons he can look at this as part of that work. It might be a bit before we release a fix though.

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Icons Needs: Investigation The Shield Dev should investigate this issue and propose a fix Resolution: Soft Close Soft closing inactive issues over a certain period
Projects
None yet
Development

No branches or pull requests

6 participants