Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to use brand (O365) multi-color icons #14151

Closed
ChrisAckermanMS opened this issue Jul 21, 2020 · 3 comments
Closed

No way to use brand (O365) multi-color icons #14151

ChrisAckermanMS opened this issue Jul 21, 2020 · 3 comments
Assignees
Labels

Comments

@ChrisAckermanMS
Copy link

Environment Information

  • Package version(s): Latest (7)
  • Browser and OS versions: N/A

Please provide a reproduction of the bug in a codepen:

https://codepen.io/ChrisAckermanMS/pen/eYJxJjO

Actual behavior:

There appears to be no way to show one of the O365 multi-color brand icons mentioned here: https://developer.microsoft.com/en-us/fluentui#/styles/web/office-brand-icons#branded-icon-library

Expected behavior:

I would expect the <Icon> component to be able to show the O365 multi-color brand icons if given the correct iconName property value.

Priorities and help requested:

Are you willing to submit a PR to fix? Maybe

Requested priority: Normal

Products/sites affected: https://myaccount.microsoft.com (localization settings).

@xugao xugao assigned Jahnp and xugao Jul 23, 2020
@xugao xugao added Area: Icons Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Jul 23, 2020
@xugao
Copy link
Contributor

xugao commented Jul 23, 2020

@Jahnp - could you help answer this one? thanks!

@Jahnp
Copy link
Member

Jahnp commented Jul 23, 2020

Thanks for flagging @xugao .

This is super valid feedback, and this functionality has been desired for some time, but unfortuately there is currently no first-class support for the multi-color brand icons with the <Icon> component. There would probably need to be custom icon registrations for each brand/size/image type (SVG or PNG).

We'd considered adding a <BrandIcon> component in the past to support the unique needs of the branded assets, but that idea never got far. <Icon> could probably be extended as well.

As is, I'd consider this a feature request that needs more investigation and a design proposal. Adding @micahgodbolt for visibility as I'm not sure who'd be the next best general icons contact.

@xugao xugao added Needs: Backlog review Type: Feature and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Jul 23, 2020
@xugao xugao assigned paulgildea and unassigned xugao Jul 23, 2020
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants