Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all form associated elements can be required #3483

Closed
nicholasrice opened this issue Jul 9, 2020 · 2 comments
Closed

Not all form associated elements can be required #3483

nicholasrice opened this issue Jul 9, 2020 · 2 comments
Labels
bug A bug closed:obsolete No longer valid improvement A non-feature-adding improvement

Comments

@nicholasrice
Copy link
Contributor

FormAssociated supports the required property and attribute. There are cases (notably switch) that do not support being required per the ARIA spec (#3458). PR #3478 removes the aria-required attribute from the template, but the FASTSwitch still supports the required property and attribute because it extends FormAssociated.

We should refactor FormAssociated so that properties can be opt-it or opt-out and so that components like Switch can form-associated without exposing properties it should not have.
@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Jul 9, 2020
@nicholasrice nicholasrice added the bug A bug label Jul 9, 2020
@triage-new-issues triage-new-issues bot removed the status:triage New Issue - needs triage label Jul 9, 2020
@EisenbergEffect EisenbergEffect added area:fast-foundation Pertains to fast-foundation improvement A non-feature-adding improvement labels Jul 20, 2020
@EisenbergEffect EisenbergEffect mentioned this issue Aug 21, 2020
Closed
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@janechu janechu added closed:obsolete No longer valid and removed area:fast-foundation Pertains to fast-foundation labels May 28, 2024
@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label May 28, 2024
@janechu
Copy link
Collaborator

janechu commented May 28, 2024

Closing per #6955

@janechu janechu closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug closed:obsolete No longer valid improvement A non-feature-adding improvement
Projects
Architecture
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EisenbergEffect @nicholasrice @janechu